Paths

Table of Contentst

Differential D6675

[native] Include `primaryIdentityPublicKey` in `register` request
ClosedPublic
Actions

Authored by atul on Feb 9 2023, 12:53 PM.

Tags

None

Referenced Files

	F3248350: D6675.diff
	Fri, Nov 15, 9:30 AM

	Unknown Object (File)
	Sun, Nov 10, 6:41 AM

	Unknown Object (File)
	Sun, Nov 10, 6:41 AM

	Unknown Object (File)
	Sun, Nov 10, 6:41 AM

	Unknown Object (File)
	Sun, Nov 10, 6:41 AM

	Unknown Object (File)
	Sun, Nov 10, 6:41 AM

	Unknown Object (File)
	Sun, Nov 10, 6:41 AM

	Unknown Object (File)
	Sun, Nov 10, 6:40 AM

Subscribers

None

Details

Reviewers

ashoat
tomek

Commits

rCOMMdd701e886ae8: [native] Include `primaryIdentityPublicKey` in `register` request

Summary

Include primaryIdentityPublicKey in register request from native.

Depends on D6674

Test Plan

Set breakpoint in accountCreationResponder:

Diff Detail

Repository

Branch

arcpatch-D6675_1 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Feb 9 2023, 12:53 PM

atul published this revision for review.Feb 9 2023, 12:54 PM

atul edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B16314: Diff 22316.Feb 9 2023, 1:08 PM

resolve merge conflicts

rebase

Harbormaster completed remote builds in B16447: Diff 22484.Feb 13 2023, 10:31 AM

Harbormaster completed remote builds in B16450: Diff 22487.Feb 13 2023, 10:45 AM

ashoat added a parent revision: D6674: [keyserver] Modify `registerRequestInputValidator` to handle `primaryIdentityPublicKey`.Feb 13 2023, 11:00 AM

ashoat added a child revision: D6719: [web] Move `setPrimaryIdentityPublicKey` up from `SIWELoginForm` to `LoginForm`.

atul edited the summary of this revision. (Show Details)Feb 13 2023, 11:01 AM

atul mentioned this in D6719: [web] Move `setPrimaryIdentityPublicKey` up from `SIWELoginForm` to `LoginForm`.

ashoat accepted this revision.Feb 13 2023, 11:04 AM

ashoat added inline comments.

native/account/register-panel.react.js
333 ↗	(On Diff #22487)	Nit – I would destructure this and assign to a local to avoid repeating `this.props.`
484 ↗	(On Diff #22487)	Hmm... looks like this will add a spinner to the button, which is weird since it sort of implies that the request has been sent. It also blocks the `TextInput`, which isn't really necessary... I think we would just want to disable the button (Probably not a big deal since `commCoreModule.getUserPublicKey` should presumably be quite fast)

This revision is now accepted and ready to land.Feb 13 2023, 11:04 AM

destructure

atul added inline comments.Feb 13 2023, 4:11 PM

native/account/register-panel.react.js
484 ↗	(On Diff #22487)	Ah, I remember intending to add a `disabled` prop to `PanelButton`... I'll update this diff in place. Will also sneak in corresponding change to `LoginPanel`.

disable button instead of setting loadingStatus to loading if primaryIdentityPublicKey is null or undefined

This revision was landed with ongoing or failed builds.Feb 13 2023, 4:22 PM

Closed by commit rCOMMdd701e886ae8: [native] Include `primaryIdentityPublicKey` in `register` request (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMdd701e886ae8: [native] Include `primaryIdentityPublicKey` in `register` request.

Harbormaster completed remote builds in B16463: Diff 22508.Feb 13 2023, 4:23 PM

Harbormaster completed remote builds in B16464: Diff 22509.Feb 13 2023, 4:34 PM

Revision Contents
Changeset List

Path

Size

lib/

types/

account-types.js

1 line

native/

account/

register-panel.react.js

29 lines

Diff 22508

lib/types/account-types.js

Loading...

native/account/register-panel.react.js

Loading...