Page MenuHomePhabricator

[landing] Add `ConnectedWalletInfo` to native SIWE flow
ClosedPublic

Authored by atul on Feb 7 2023, 12:44 PM.
Tags
None
Referenced Files
F3492538: D6652.id22812.diff
Thu, Dec 19, 12:14 AM
F3492536: D6652.id22901.diff
Thu, Dec 19, 12:13 AM
F3492161: D6652.diff
Wed, Dec 18, 10:20 PM
F3488587: D6652.id22235.diff
Wed, Dec 18, 10:48 AM
Unknown Object (File)
Sat, Dec 14, 2:00 PM
Unknown Object (File)
Fri, Nov 22, 1:44 AM
Unknown Object (File)
Fri, Nov 22, 1:44 AM
Unknown Object (File)
Fri, Nov 22, 1:44 AM
Subscribers
None

Details

Summary

Use the same ConnectedWalletInfo from web on landing to match styling.

Test Plan

Looks as expected (there's obviously additional work to do here):

Simulator Screen Shot - iPhone 14 Pro - 2023-02-21 at 01.18.01.png (2×1 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Feb 7 2023, 12:46 PM
atul added inline comments.
landing/reset.css
4–11 ↗(On Diff #22233)

Idk what this is, but it was messing with my ConnectedWalletInfo layout.

Removing it didn't seem to break anything on landing (did a quick scan of most pages)

ashoat requested changes to this revision.Feb 8 2023, 6:15 AM
ashoat added inline comments.
landing/reset.css
4–11 ↗(On Diff #22233)

This is a pretty significant change

Honestly box-sizing: border-box is a better default than content-box

I'd rather see you add box-sizing: border-box to your component and make this explicit on web, and then adjust it to look right

If you feel strongly about preferring box-sizing: content-box, we should at least add git grep width and git grep height to the Test Plan, and look for any place that has a border or padding defined

This revision now requires changes to proceed.Feb 8 2023, 6:15 AM
This revision now requires changes to proceed.Feb 17 2023, 12:13 AM

address feedback

ashoat added inline comments.
lib/components/connected-wallet-info.css
22 ↗(On Diff #22812)

Not sure why we need this still but it looks like it's not affecting too much

This revision is now accepted and ready to land.Feb 21 2023, 6:28 AM
This revision was landed with ongoing or failed builds.Feb 21 2023, 4:59 PM
This revision was automatically updated to reflect the committed changes.