Details

Reviewers

ashoat
tomek
atul

Commits

rCOMM00510eaa214f: [keyserver] convert existing logic for building userPushInfoPromises to an…

Summary

The logic for building userPushInfoPromise will be really simlar when we build userRescindInfoPromise so I built generateNotifUserInfoPromise to reuse this logic in a subseqent diff

Depends on D6307
Linear Task: ENG-2644

Test Plan

flow and please see video showing no regressions with the notifications.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Feb 21 2023, 10:46 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 21 2023, 10:46 PM

ginsu edited the summary of this revision. (Show Details)Feb 21 2023, 10:49 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, tomek, atul.

ginsu added a parent revision: D6307: [lib] modify reaction message generatesNotifs function to return a pushType based on the reaction action.

ginsu attached a referenced file: F396108: Screen Recording 2023-02-22 at 1.37.09 AM.mov. (Show Details)

fix import ordering

Harbormaster completed remote builds in B16751: Diff 22911.Feb 21 2023, 11:00 PM

Harbormaster completed remote builds in B16752: Diff 22912.Feb 21 2023, 11:07 PM

ginsu requested review of this revision.Feb 21 2023, 11:07 PM

ginsu added a child revision: D6830: [keyserver] introduce sendRescindNotifs.Feb 21 2023, 11:40 PM

ashoat requested changes to this revision.Feb 22 2023, 11:09 AM

ashoat added inline comments.

keyserver/src/creators/message-creator.js
428	Why isn't this an `async` function? If you're returning a `Promise`, you should pretty much always use await / async

This revision now requires changes to proceed.Feb 22 2023, 11:09 AM

address ashoat's comments

Harbormaster completed remote builds in B16839: Diff 23018.Feb 23 2023, 9:06 AM

You need to do more than just add async. I don't think you have a full understanding of async/await here

This revision now requires changes to proceed.Feb 23 2023, 12:02 PM

atul added 1 blocking reviewer(s): atul.Feb 24 2023, 2:09 PM

address ashoat's comments

ginsu retitled this revision from [keyserver] convert existing logic for building userPushInfoPromises to an IIFE called generateNotifUserInfoPromise to [keyserver] convert existing logic for building userPushInfoPromises to an async function called generateNotifUserInfoPromise.Feb 24 2023, 4:55 PM

Harbormaster completed remote builds in B16903: Diff 23094.Feb 24 2023, 5:10 PM

ashoat accepted this revision.Feb 26 2023, 5:38 AM

ashoat removed 1 blocking reviewer(s): atul.

This revision is now accepted and ready to land.Feb 26 2023, 5:38 AM

rebase before landing

Harbormaster completed remote builds in B16912: Diff 23103.Feb 26 2023, 11:27 AM

Closed by commit rCOMM00510eaa214f: [keyserver] convert existing logic for building userPushInfoPromises to an… (authored by ginsu). · Explain WhyFeb 26 2023, 1:06 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM00510eaa214f: [keyserver] convert existing logic for building userPushInfoPromises to an….