[web] Dispatch `setNotificationIdentityKeys` in `LoginForm`
ClosedPublic
Actions

Authored by atul on Feb 23 2023, 6:55 PM.

Details

Reviewers

ashoat
tomek
marcin

Commits

rCOMM21d6d9f1bfa1: [web] Dispatch `setNotificationIdentityKeys` in `LoginForm`

Summary

Create notificationAccount, get identity_keys(), and dispatch setNotificationIdentityKeys action to store in Redux cryptoStore.

Note that all the logic on whether to eg enable login button, etc is still only dependent on identityED25519... this will be addressed in subsequent diffs.

Depends on D6877

Test Plan

Actions are being dispatched correctly and cryptoStore in Redux is as expected:

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Feb 23 2023, 6:55 PM

atul edited the summary of this revision. (Show Details)Feb 23 2023, 6:56 PM

atul added a parent revision: D6877: [web] Introduce `cryptoStore` to replace `primaryIdentityPublicKey` in Redux.

atul edited the test plan for this revision. (Show Details)

atul added inline comments.Feb 23 2023, 6:58 PM

web/account/log-in-form.react.js
55–62 ↗	(On Diff #23042)	We have two separate actions here... `setPrimaryIdentityKeys` and `setNotificationIdentityKeys` instead of a single `setCryptoStore`. I wasn't sure how coupled we wanted the two to be/if they'd need to be changed independently in the future... so I kept them separate. Can always "merge" the actions in the future?

atul published this revision for review.Feb 23 2023, 6:59 PM

Harbormaster completed remote builds in B16863: Diff 23042.Feb 23 2023, 7:11 PM

atul added a child revision: D6879: [web] Update `LoginForm` `useEffect` early-exit logic to include `notificationIdentityPublicKeys`.Feb 23 2023, 7:20 PM

atul added a reviewer: marcin.Feb 24 2023, 2:21 AM

ashoat accepted this revision.Feb 24 2023, 8:15 AM

ashoat added inline comments.

web/account/log-in-form.react.js
55–62 ↗	(On Diff #23042)	I imagine these will be coupled long-term, but not sure how much this matters and don't want to block this from landing right now
web/redux/crypto-store-reducer.js
13 ↗	(On Diff #23042)	Nit: add a newline after this