Page MenuHomePhabricator
Differential D6883

[web] Pickle `OLMAccount`s and add to Redux `CryptoStore`
ClosedPublic
Actions

Authored by atul on Feb 24 2023, 12:43 AM.
Tags
None
Referenced Files
F3339313: D6883.diff
Thu, Nov 21, 7:41 PM
Unknown Object (File)
Sun, Nov 10, 7:02 PM
Unknown Object (File)
Sun, Nov 10, 7:02 PM
Unknown Object (File)
Sun, Nov 10, 7:02 PM
Unknown Object (File)
Sun, Nov 10, 7:01 PM
Unknown Object (File)
Tue, Nov 5, 2:09 AM
Unknown Object (File)
Wed, Oct 23, 6:16 PM
Unknown Object (File)
Wed, Oct 23, 5:41 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
marcin
Commits
rCOMM6151beabc857: [web] Pickle `OLMAccount`s and add to Redux `CryptoStore`
Summary

We pickle the OLMAccounts and add them to Redux CryptoStore so the olm.Account can be "unpickled" later for eg signing a message.

Depends on D6882

Test Plan

Pickled accounts appear in Redux CryptoStore as expected:

8bc940.png (1×2 px, 522 KB)

(Yes, there are four separate actions being dispatched at the moment. Once things are working end-to-end we can refactor/consolidate as needed.)

"Unpickling" will be tested in subsequent diffs.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 24 2023, 12:43 AM
atul published this revision for review.Feb 24 2023, 12:44 AM
atul edited the summary of this revision. (Show Details)
atul added a parent revision: D6882: [web] Add `PickledOLMAccount`s to Redux `CryptoStore`.
atul added inline comments.
web/account/log-in-form.react.js
49–91 ↗(On Diff #23047)

This useEffect is getting massive. Going to extract this out into a hook in a later diff once things are working end-to-end.

atul edited the test plan for this revision. (Show Details)Feb 24 2023, 12:45 AM
atul edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B16868: Diff 23047.Feb 24 2023, 12:58 AM
atul added a child revision: D6884: [web] "Unpickle" primary OLM account to sign keys and get `SignedIdentityKeysBlob`.Feb 24 2023, 2:21 AM
atul added a reviewer: marcin.Feb 24 2023, 2:22 AM
ashoat accepted this revision.Feb 24 2023, 8:19 AM
This revision is now accepted and ready to land.Feb 24 2023, 8:19 AM
atul updated this revision to Diff 23083.Feb 24 2023, 2:29 PM

merge conflict

This revision was landed with ongoing or failed builds.Feb 24 2023, 2:39 PM
Closed by commit rCOMM6151beabc857: [web] Pickle `OLMAccount`s and add to Redux `CryptoStore` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM6151beabc857: [web] Pickle `OLMAccount`s and add to Redux `CryptoStore`.
Harbormaster completed remote builds in B16901: Diff 23083.Feb 24 2023, 2:45 PM

Revision Contents
Changeset List

PathSize
web/
account/
29 lines
1 line
redux/
14 lines
14 lines

Diff 23083

View Options

web/account/log-in-form.react.js

Loading...
View Options

web/package.json

Loading...
View Options

web/redux/crypto-store-reducer.js

Loading...
View Options

web/redux/redux-setup.js

Loading...