[lib] Sanitize Redux `CryptoStore`
ClosedPublic
Actions

Authored by atul on Mar 2 2023, 1:18 PM.

Details

Reviewers

ashoat
tomek
marcin

Commits

rCOMM807b989e5ef9: [lib] Sanitize Redux `CryptoStore`

Summary

Add keys to keysWithStringsToBeRedacted to properly redact CryptoStore.

Test Plan

Checked Redux dev tools to make sure I got the keys right:

Ran sanitizeAction and sanitizeState on the CryptoStore actions and state afterwards and ensured things were as expected:

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 2 2023, 1:18 PM

atul edited the test plan for this revision. (Show Details)Mar 2 2023, 1:26 PM

atul edited the test plan for this revision. (Show Details)Mar 2 2023, 1:29 PM

Harbormaster completed remote builds in B17064: Diff 23366.Mar 2 2023, 1:32 PM

atul requested review of this revision.Mar 2 2023, 1:32 PM

atul edited the test plan for this revision. (Show Details)Mar 2 2023, 1:42 PM

ashoat accepted this revision.Mar 2 2023, 1:46 PM

This revision is now accepted and ready to land.Mar 2 2023, 1:46 PM

Closed by commit rCOMM807b989e5ef9: [lib] Sanitize Redux `CryptoStore` (authored by atul). · Explain WhyMar 2 2023, 2:17 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM807b989e5ef9: [lib] Sanitize Redux `CryptoStore`.

Revision Contents
Changeset List

Path

Size

lib/

utils/

sanitization.js

4 lines

Diff 23366

View Options

[lib] Sanitize Redux `CryptoStore`ClosedPublicActions