Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash"
ClosedPublic
Actions

Authored by marcin on Mar 7 2023, 1:37 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMM2453e10d5b13: Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash"

Summary

This reverts commit 980305ee4c956ab22e1577a0d1d810c269e0d80b.

Test Plan

Build Android app and ensure the crash fixed by counterpart diff reoccurs

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Mar 7 2023, 1:37 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 7 2023, 1:37 PM

marcin added a child revision: D6959: Run everuthing regarding NotificationsCryptoModule with native Android Accessible.Mar 7 2023, 1:38 PM

Harbormaster completed remote builds in B17153: Diff 23493.Mar 7 2023, 1:53 PM

marcin requested review of this revision.Mar 7 2023, 1:53 PM

(Please don't land until D6959 is accepted and ready to land as well)

This revision is now accepted and ready to land.Mar 7 2023, 2:27 PM

Rebase before landing

Harbormaster completed remote builds in B17178: Diff 23526.Mar 8 2023, 10:29 AM

Closed by commit rCOMM2453e10d5b13: Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash". · Explain WhyMar 8 2023, 11:01 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM2453e10d5b13: Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash".

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

99 lines

Notifications/

BackgroundDataStorage/

NotificationsCryptoModule.h

6 lines

NotificationsCryptoModule.cpp

16 lines

Diff 23526

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.h

View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp

Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 23526

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.h

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp

Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash"
ClosedPublic
Actions

Revision Contents
Changeset List