Page MenuHomePhabricator
Differential D6980

Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash"
ClosedPublic
Actions

Authored by marcin on Mar 7 2023, 5:37 AM.
Tags
None
Referenced Files
F3492331: D6980.diff
Wed, Dec 18, 11:10 PM
Unknown Object (File)
Sat, Dec 14, 8:11 AM
Unknown Object (File)
Sat, Dec 14, 8:11 AM
Unknown Object (File)
Sat, Dec 14, 8:11 AM
Unknown Object (File)
Sat, Dec 14, 8:10 AM
Unknown Object (File)
Sat, Dec 14, 8:05 AM
Unknown Object (File)
Wed, Dec 4, 7:48 AM
Unknown Object (File)
Wed, Dec 4, 7:48 AM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMM2453e10d5b13: Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash"
Summary

This reverts commit 980305ee4c956ab22e1577a0d1d810c269e0d80b.

Test Plan

Build Android app and ensure the crash fixed by counterpart diff reoccurs

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
99 lines
Notifications/
BackgroundDataStorage/
6 lines
16 lines

Diff 23529

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.h

Loading...
View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp

Loading...