Context: https://linear.app/comm/issue/ENG-3213#comment-706a284f
Should reduce yarn cleaninstall time by a significant-ish amount.
Details
Details
Didn't do any thorough profiling, but things appear to
A. be faster
B. be continuing to work as expected
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- arcpatch-D7021 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| keyserver/addons/rust-node-addon/package.json | ||
|---|---|---|
| 36 ↗ | (On Diff #23582) | we probably don't need the install-ci-deps part here now |
| keyserver/addons/rust-node-addon/package.json | ||
|---|---|---|
| 36 ↗ | (On Diff #23582) | true |
Comment Actions
Did we make sure this passed keyserver Docker build before landing? Just want to make that sure that running build:debug before we run build doesn't break build (doubt it)
Comment Actions
Did we make sure this passed keyserver Docker build before landing?
Yeah was tested as part of https://phab.comm.dev/B17218 before the last revision of the diff. The last revision of the diff just removed yarn install-ci-deps from yarn build... which isn't used anywhere
Comment Actions
Ah, but we probably DO want yarn build on prod. As @varun said:
yeah we can use debug by default on dev machines
But we should still do release for prod. I'll revert this.
Comment Actions
JK, I shouldn't have just searched yarn build... should've considered that yarn scripts can be invoked via yarn workspace blah command.
