[keyserver] Update `fetchKnownUserInfos` to include `avatar` field in `UserInfo`s
ClosedPublic
Actions

Authored by atul on Mar 27 2023, 1:40 PM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMMe2deb3803a31: [keyserver] Update `fetchKnownUserInfos` to include `avatar` field in…

Summary

We want to make sure that we're populating the avatar field if set.

Test Plan

Logged results from query and observed that "other" user avatar was populated in Redux:

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D7203_1 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 27 2023, 1:40 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 27 2023, 1:40 PM

atul published this revision for review.Mar 27 2023, 1:40 PM

atul added reviewers: ashoat, ginsu.

atul edited the test plan for this revision. (Show Details)

atul added inline comments.

keyserver/src/fetchers/user-fetchers.js
50 ↗	(On Diff #24235)	Noticed a fix that needed to be made

Harbormaster completed remote builds in B17707: Diff 24235.Mar 27 2023, 1:55 PM

ashoat accepted this revision.Mar 27 2023, 4:27 PM

This revision is now accepted and ready to land.Mar 27 2023, 4:27 PM

rebase and land

This revision was landed with ongoing or failed builds.Mar 28 2023, 12:46 PM

Closed by commit rCOMMe2deb3803a31: [keyserver] Update `fetchKnownUserInfos` to include `avatar` field in… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMe2deb3803a31: [keyserver] Update `fetchKnownUserInfos` to include `avatar` field in….

Harbormaster completed remote builds in B17767: Diff 24312.Mar 28 2023, 12:57 PM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

user-fetchers.js

27 lines

Diff 24312

View Options

keyserver/src/fetchers/user-fetchers.js

[keyserver] Update `fetchKnownUserInfos` to include `avatar` field in `UserInfo`sClosedPublicActions