Page MenuHomePhabricator
Differential D7263

[native] switch all thread avatars to use ThreadAvatar component instead of Avatar
ClosedPublic
Actions

Authored by ginsu on Mar 30 2023, 3:13 PM.
Tags
None
Referenced Files
F3520222: D7263.diff
Sun, Dec 22, 11:38 PM
Unknown Object (File)
Fri, Dec 6, 9:54 PM
Unknown Object (File)
Thu, Dec 5, 8:38 PM
Unknown Object (File)
Thu, Dec 5, 8:38 PM
Unknown Object (File)
Thu, Dec 5, 8:38 PM
Unknown Object (File)
Wed, Dec 4, 3:34 AM
Unknown Object (File)
Wed, Dec 4, 3:33 AM
Unknown Object (File)
Tue, Nov 26, 7:14 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMMb1544e6f0d73: [native] switch all thread avatars to use ThreadAvatar component instead of…
Summary

Now that we have ThreadAvatar we should render that for thread avatars instead of Avatar

Depends on D7262

Test Plan

Tested that all the thread avatars are still able to be rendered correctly for all three avatar types (emoji, image, and ens)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Mar 30 2023, 3:13 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 30 2023, 3:13 PM
ginsu edited the summary of this revision. (Show Details)Mar 30 2023, 3:15 PM
ginsu added reviewers: ashoat, atul.
ginsu added a parent revision: D7262: [native] introude thread avatar component.
Harbormaster completed remote builds in B17851: Diff 24447.Mar 30 2023, 3:29 PM
ginsu requested review of this revision.Mar 30 2023, 3:29 PM
ashoat requested changes to this revision.Mar 30 2023, 5:50 PM

In all of these cases we already have the threadInfo. Instead of requiring ThreadAvatar to fetch it again, should we just pass it in directly?

This revision now requires changes to proceed.Mar 30 2023, 5:50 PM
ashoat mentioned this in D7262: [native] introude thread avatar component.Mar 30 2023, 5:51 PM
ginsu updated this revision to Diff 24454.Mar 30 2023, 11:07 PM

address ashoat's comments

ginsu added a child revision: D7264: [lib/native] change useGetAvatarForThread to useAvatarForThread.Mar 30 2023, 11:11 PM
Harbormaster completed remote builds in B17857: Diff 24454.Mar 30 2023, 11:22 PM
ashoat accepted this revision.Mar 31 2023, 5:30 AM
This revision is now accepted and ready to land.Mar 31 2023, 5:30 AM
ginsu updated this revision to Diff 24511.Mar 31 2023, 8:39 AM

rebase before landing

Harbormaster completed remote builds in B17895: Diff 24511.Mar 31 2023, 8:55 AM
Closed by commit rCOMMb1544e6f0d73: [native] switch all thread avatars to use ThreadAvatar component instead of… (authored by ginsu). · Explain WhyMar 31 2023, 9:38 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMb1544e6f0d73: [native] switch all thread avatars to use ThreadAvatar component instead of….

Revision Contents
Changeset List

Diff 24454

View Options

native/chat/chat-thread-list-item.react.js

Loading...
View Options

native/chat/message-list-header-title.react.js

Loading...
View Options

native/chat/settings/thread-settings-avatar.react.js

Loading...
View Options

native/chat/settings/thread-settings-child-thread.react.js

Loading...
View Options

native/chat/settings/thread-settings-parent.react.js

Loading...
View Options

native/components/thread-list-thread.react.js

Loading...
View Options

native/navigation/community-drawer-item.react.js

Loading...