Page MenuHomePhabricator

[native] introduce ColorRows component
ClosedPublic

Authored by ginsu on Apr 4 2023, 12:30 PM.
Tags
None
Referenced Files
F3390848: D7302.diff
Sat, Nov 30, 1:13 AM
Unknown Object (File)
Tue, Nov 26, 11:30 PM
Unknown Object (File)
Tue, Nov 26, 9:47 PM
Unknown Object (File)
Fri, Nov 8, 9:56 AM
Unknown Object (File)
Fri, Nov 8, 9:56 AM
Unknown Object (File)
Tue, Nov 5, 10:24 PM
Unknown Object (File)
Tue, Nov 5, 10:24 PM
Unknown Object (File)
Tue, Nov 5, 2:23 AM
Subscribers

Details

Summary

For the emoji avatar creation flow we want the same color rows logic that are found in ColorSelector. I factored out this logic into its own component so that we can better resuse it in both places

Test Plan

There were no regressions, and ColorSelector looks and behaves as it did previously.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Apr 4 2023, 12:47 PM
ashoat added inline comments.
native/components/color-selector.react.js
55–58 ↗(On Diff #24635)

Think you forgot to remove this

This revision is now accepted and ready to land.Apr 4 2023, 1:43 PM
native/components/color-selector.react.js
55–58 ↗(On Diff #24635)

yea you are totally right thanks for catching that!

ginsu edited the test plan for this revision. (Show Details)

address ashoat's comments

This revision was automatically updated to reflect the committed changes.