[keyserver] Update `thread-fetchers` to handle image avatars
ClosedPublic
Actions

Authored by atul on Apr 11 2023, 6:31 PM.

Details

Reviewers

ginsu
ashoat

Commits

rCOMMb2dfacfc6652: [keyserver] Update `thread-fetchers` to handle image avatars

Summary

Update the queries in thread-fetchers to fetch upload_id and upload_secret from uploads table to create upload URL and include in ClientAvatar.

Test Plan

Set breakpoints after each query and observed result set and that the ClientAvatars were constructed correctly.

Verified that I was able to see image avatars on native client:
[will add screenshots shortly]

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D7393 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 11 2023, 6:31 PM

Herald added a subscriber: tomek. · View Herald TranscriptApr 11 2023, 6:31 PM

Harbormaster completed remote builds in B18264: Diff 25025.Apr 11 2023, 6:50 PM

atul requested review of this revision.Apr 11 2023, 6:50 PM

ashoat accepted this revision.Apr 12 2023, 6:27 AM

This revision is now accepted and ready to land.Apr 12 2023, 6:27 AM

rebase before landing

This revision was landed with ongoing or failed builds.Apr 12 2023, 9:19 AM

Closed by commit rCOMMb2dfacfc6652: [keyserver] Update `thread-fetchers` to handle image avatars (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMb2dfacfc6652: [keyserver] Update `thread-fetchers` to handle image avatars.

Harbormaster completed remote builds in B18272: Diff 25043.Apr 12 2023, 9:35 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

thread-fetchers.js

31 lines

Diff 25043

View Options

keyserver/src/fetchers/thread-fetchers.js

[keyserver] Update `thread-fetchers` to handle image avatarsClosedPublicActions