Page MenuHomePhabricator
Differential D7439

[keyserver] Get rid of `versions` table and related endpoints
ClosedPublic
Actions

Authored by atul on Apr 13 2023, 4:03 PM.
Tags
None
Referenced Files
F2210965: D7439.id25177.diff
Mon, Jul 8, 12:47 AM
F2209156: D7439.id.diff
Sun, Jul 7, 4:10 PM
Unknown Object (File)
Fri, Jul 5, 2:32 PM
Unknown Object (File)
Fri, Jul 5, 3:23 AM
Unknown Object (File)
Sat, Jun 29, 5:25 PM
Unknown Object (File)
Fri, Jun 28, 8:23 AM
Unknown Object (File)
Tue, Jun 25, 5:40 PM
Unknown Object (File)
Fri, Jun 21, 4:11 AM
View All 69 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM3ae2c4ef4551: [keyserver] Get rid of `versions` table and related endpoints
Summary

We're not using this table and don't have any immediate plans to do so. If we do need to get the data versions was designed to store, we can easily get itfrom GitHub/AppStoreConnect/PlayStore APIs.

Context:
https://linear.app/comm/issue/ENG-3633/compute-equivalent-of-versions-table-using-ghappstoreplaystore-apis

https://linear.app/comm/issue/ENG-2428/compute-equivalent-of-keyserver-versions-table-with

Test Plan

Ran migration and my versions table is gone:

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
keyserver/
src/
database/
6 lines
12 lines
14 lines
responders/
lib/
types/

Diff 25149

View Options

keyserver/src/database/migration-config.js

Loading...
View Options

keyserver/src/database/setup-db.js

Loading...
View Options

keyserver/src/keyserver.js

Loading...
View Options

keyserver/src/responders/version-responders.js

Loading...
View Options

lib/types/version-types.js

Loading...