Page MenuHomePhabricator
Differential D7456

[native] fix Android cancel action sheet crash
ClosedPublic
Actions

Authored by ginsu on Apr 16 2023, 10:51 AM.
Tags
None
Referenced Files
F3387382: D7456.id25201.diff
Fri, Nov 29, 9:11 AM
Unknown Object (File)
Mon, Nov 25, 9:55 PM
Unknown Object (File)
Mon, Nov 25, 7:29 PM
Unknown Object (File)
Thu, Nov 21, 11:55 PM
Unknown Object (File)
Thu, Nov 21, 11:55 PM
Unknown Object (File)
Thu, Nov 21, 11:55 PM
Unknown Object (File)
Thu, Nov 21, 11:55 PM
Unknown Object (File)
Thu, Nov 21, 11:55 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMM39a557c86168: [native] fix Android cancel action sheet crash
Summary

While testing the edit avatar flow for android, I encountered this bug where the app crashes when the user presses anywhere outside the actionsheet. The reason for this is that the value of selectedIndex when a user tries to cancel on android is -1, and the value of selectedIndex when a user tries to cancel on iOS is 0. This is due to action sheets on android generally not having a cancel option in the sheet but there being a cancel option with iOS

Test Plan

No longer triggering the crash, and we are getting the expected cancel behavior. Also double checked that iOS still behaves as expected

Before:

After:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 16 2023, 10:51 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 16 2023, 10:51 AM
ginsu edited the summary of this revision. (Show Details)Apr 16 2023, 10:57 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, atul.
ginsu attached a referenced file: F488564: Screen Recording 2023-04-16 at 1.41.33 PM.mov. (Show Details)
ginsu attached a referenced file: F488563: Screen Recording 2023-04-16 at 1.38.09 PM.mov. (Show Details)
ginsu edited the test plan for this revision. (Show Details)Apr 16 2023, 11:06 AM
ginsu attached a referenced file: F488568: Screen Recording 2023-04-16 at 2.06.10 PM.mov. (Show Details)
Harbormaster completed remote builds in B18388: Diff 25194.Apr 16 2023, 11:09 AM
ginsu requested review of this revision.Apr 16 2023, 11:09 AM
ginsu added a child revision: D7457: [native] add safe area insets for android action sheet.Apr 16 2023, 11:12 AM
ginsu planned changes to this revision.Apr 16 2023, 11:21 AM
ginsu updated this revision to Diff 25196.Apr 16 2023, 11:59 AM

use cancel function

ginsu updated this revision to Diff 25198.Apr 16 2023, 12:01 PM

fix dep order

Harbormaster completed remote builds in B18390: Diff 25196.Apr 16 2023, 12:17 PM
Harbormaster completed remote builds in B18392: Diff 25198.Apr 16 2023, 12:20 PM
ginsu updated this revision to Diff 25200.Apr 16 2023, 12:29 PM

fix conditional

ginsu added inline comments.Apr 16 2023, 12:31 PM
native/tooltip/tooltip-context.react.js
121–122 ↗(On Diff #25200)

We can't use !selectedIndex because this will evaluate to true when selectedIndex is equal to zero

Harbormaster completed remote builds in B18394: Diff 25200.Apr 16 2023, 12:48 PM
ashoat accepted this revision.Apr 16 2023, 2:02 PM
This revision is now accepted and ready to land.Apr 16 2023, 2:02 PM
Closed by commit rCOMM39a557c86168: [native] fix Android cancel action sheet crash (authored by ginsu). · Explain WhyApr 16 2023, 3:39 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM39a557c86168: [native] fix Android cancel action sheet crash.

Revision Contents
Changeset List

PathSize
native/
tooltip/
13 lines

Diff 25194

View Options

native/tooltip/tooltip-context.react.js

Loading...