[native] Fix error check condition
ClosedPublic
Actions

Authored by atul on Apr 19 2023, 1:53 PM.

Tags

None

Referenced Files

	F3156864: D7542.id25409.diff
	Tue, Nov 5, 5:45 PM

	F3156861: D7542.id25411.diff
	Tue, Nov 5, 5:43 PM

	Unknown Object (File)
	Fri, Nov 1, 9:13 AM

	Unknown Object (File)
	Fri, Nov 1, 9:13 AM

	Unknown Object (File)
	Fri, Nov 1, 9:13 AM

	Unknown Object (File)
	Fri, Nov 1, 9:12 AM

	Unknown Object (File)
	Fri, Nov 1, 9:10 AM

	Unknown Object (File)
	Oct 1 2024, 12:31 PM

View All 83 Files

Subscribers

tomek

Details

Reviewers

ashoat
ginsu

Commits

rCOMM4fdefafb4868: [native] Fix error check condition

Summary

In the D7530 Test Plan I mention:

Flipped boolean and observed that Alert appeared as expected

Well, looks like I included the flipped condition in the diff... thankfully it was easy to catch.

Test Plan

Setting image avatar works again

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 19 2023, 1:53 PM

Herald added a subscriber: tomek. · View Herald TranscriptApr 19 2023, 1:53 PM

atul published this revision for review.Apr 19 2023, 1:54 PM

ginsu accepted this revision.Apr 19 2023, 1:56 PM

This revision is now accepted and ready to land.Apr 19 2023, 1:56 PM

rebase and land

This revision was landed with ongoing or failed builds.Apr 19 2023, 2:06 PM

Closed by commit rCOMM4fdefafb4868: [native] Fix error check condition (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM4fdefafb4868: [native] Fix error check condition.

Harbormaster completed remote builds in B18545: Diff 25409.Apr 19 2023, 2:10 PM

Harbormaster completed remote builds in B18547: Diff 25411.Apr 19 2023, 2:23 PM

Revision Contents
Changeset List

Path

Size

native/

avatars/

avatar-hooks.js

2 lines

Diff 25409

View Options

native/avatars/avatar-hooks.js

[native] Fix error check conditionClosedPublicActions