Page MenuHomePhabricator
Differential D7542

[native] Fix error check condition
ClosedPublic
Actions

Authored by atul on Apr 19 2023, 1:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 31, 2:26 AM
Unknown Object (File)
Tue, Dec 31, 2:26 AM
Unknown Object (File)
Tue, Dec 31, 2:26 AM
Unknown Object (File)
Tue, Dec 31, 2:25 AM
Unknown Object (File)
Tue, Dec 31, 2:21 AM
Unknown Object (File)
Nov 28 2024, 8:55 AM
Unknown Object (File)
Nov 28 2024, 6:44 AM
Unknown Object (File)
Nov 28 2024, 6:38 AM
View All 96 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM4fdefafb4868: [native] Fix error check condition
Summary

In the D7530 Test Plan I mention:

Flipped boolean and observed that Alert appeared as expected

Well, looks like I included the flipped condition in the diff... thankfully it was easy to catch.

Test Plan

Setting image avatar works again

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D7542 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
avatars/
2 lines

Diff 25411

View Options

native/avatars/avatar-hooks.js

Loading...