Page MenuHomePhabricator

[native] introduce use ENS avatar to edit user avatar
ClosedPublic

Authored by ginsu on Apr 19 2023, 3:14 PM.
Tags
None
Referenced Files
F3296195: D7546.id25426.diff
Sun, Nov 17, 1:33 AM
F3295868: D7546.diff
Sat, Nov 16, 11:32 PM
Unknown Object (File)
Thu, Nov 7, 7:17 PM
Unknown Object (File)
Thu, Nov 7, 6:20 PM
Unknown Object (File)
Thu, Nov 7, 1:23 AM
Unknown Object (File)
Thu, Oct 31, 9:14 PM
Unknown Object (File)
Thu, Oct 31, 9:14 PM
Unknown Object (File)
Thu, Oct 31, 9:14 PM
Subscribers

Details

Summary

Add use ens avatar to the edit user avatar action sheet. This diff also introduces useENSUserAvatar to avatar-hooks which handles the logic for saving the ens avatar into our db.

I am aware I wrote useENSUserAvatar with a bit of a naive approach, but I think the goal should be to get things working first so we can get something shipped, then make things more elegant.

Test Plan

Followed the test plan from D7462 and was able to get all the same behavoir/results

Diff Detail

Repository
rCOMM Comm
Branch
eng-2006 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

native/avatars/avatar-hooks.js
357

The structure of this hook is very similar to useRemoveUserAvatar (just above). Eventually we will factor out things in this file to reduce redundancy

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 3:37 PM
Harbormaster failed remote builds in B18561: Diff 25426!
ginsu requested review of this revision.Apr 19 2023, 3:40 PM
ginsu edited the summary of this revision. (Show Details)

rebase in atuls changes

This revision is now accepted and ready to land.Apr 19 2023, 6:15 PM
This revision was landed with ongoing or failed builds.Apr 19 2023, 6:24 PM
This revision was automatically updated to reflect the committed changes.