Page MenuHomePhabricator

[native] Delete broken Android custom font symlinks
ClosedPublic

Authored by ashoat on Apr 22 2023, 2:38 PM.
Tags
None
Referenced Files
F2714756: D7579.diff
Mon, Sep 16, 2:08 AM
Unknown Object (File)
Fri, Sep 13, 8:29 PM
Unknown Object (File)
Fri, Aug 30, 11:19 PM
Unknown Object (File)
Sat, Aug 24, 7:15 PM
Unknown Object (File)
Sat, Aug 24, 7:15 PM
Unknown Object (File)
Sat, Aug 24, 7:15 PM
Unknown Object (File)
Sat, Aug 24, 7:15 PM
Unknown Object (File)
Sat, Aug 24, 7:13 PM
Subscribers
None

Details

Summary

These symlinks are currently broken. Initially this diff fixed the symlinks, but then I realized I should just delete them since they apparently weren't needed. The Test Plan works with the files deleted, and I think it's because we're using @expo/vector-icons and expo-font to load these, and they don't need the files in this location.

The old react-native link, deprecated as of React Native 0.69, would put fonts in this folder. I think the folder still works for bundling assets with your app statically, but expo-font just doesn't need the files in that folder.

Test Plan

Make sure the CommIcon named cloud-filled still loads on Android in dev and release builds

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/fixci
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Predictably, the test plan works with these files just deleted...

ashoat retitled this revision from [native] Fix Android custom font symlinks to [native] Delete broken Android custom font symlinks.Apr 22 2023, 5:38 PM
ashoat edited the summary of this revision. (Show Details)

Wonder if older versions of Android may fallback to font?

This revision is now accepted and ready to land.Apr 22 2023, 6:14 PM

I tried testing on Android 5.1 and got this fatal instead. I'm just going to land this... I think it's unlikely that these broken symlinks were doing anything good for any version of Android