Page MenuHomePhabricator

[keyserver] `filterThreadEditAvatarPermission` based on `codeVersion` check
ClosedPublic

Authored by atul on Apr 25 2023, 1:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 5:11 PM
Unknown Object (File)
Sat, Nov 9, 5:11 PM
Unknown Object (File)
Sat, Nov 9, 5:11 PM
Unknown Object (File)
Thu, Nov 7, 9:01 PM
Unknown Object (File)
Tue, Nov 5, 8:58 AM
Unknown Object (File)
Thu, Oct 31, 3:34 PM
Unknown Object (File)
Thu, Oct 31, 3:34 PM
Unknown Object (File)
Thu, Oct 31, 3:34 PM
Subscribers

Details

Summary

We expect 213 to be the first native client with support for thread avatars. This diff will make sure EDIT_THREAD_AVATAR permissions are INCLUDED for clients >= 213 so the feature works properly.

Test Plan

Will make sure client threadInfos and keyserver threadInfos match up.

  1. Install old prod build (208?)
  2. Connect to "new" keyserver (ie keyserver after this diff is landed)
  3. Update to 213+ (which includes persist migration)
  4. Connect to "new keyserver and monitor state check mechanism

We expect that the migration will bring the client Redux state "up-to-date" (ie including EDIT_THREAD_AVATAR) and "new keyserver" will include EDIT_THREAD_AVATAR in threadInfos it computes for client... and they'll be consistent.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage