Page MenuHomePhabricator
Differential D7677

[keyserver] Fix `usersToUpdate` logic in `deleteAccount`
ClosedPublic
Actions

Authored by atul on Apr 27 2023, 1:27 PM.
Tags
None
Referenced Files
F3171163: D7677.diff
Thu, Nov 7, 1:31 PM
Unknown Object (File)
Thu, Oct 31, 2:22 PM
Unknown Object (File)
Mon, Oct 21, 4:11 PM
Unknown Object (File)
Mon, Oct 21, 4:11 PM
Unknown Object (File)
Mon, Oct 21, 4:11 PM
Unknown Object (File)
Mon, Oct 21, 4:11 PM
Unknown Object (File)
Mon, Oct 21, 4:11 PM
Unknown Object (File)
Sun, Oct 20, 11:13 AM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMMa19933fc4c62: [keyserver] Fix `usersToUpdate` logic in `deleteAccount`
Summary

Was looking at this when working on UPDATE_USER updates for updateUserAvatar and it looks like it wasn't actually excluding anything.

Test Plan

Tested updated logic in updateUserSettings.

Before:

fdbfb0.png (626×2 px, 172 KB)

After:

9d8c93.png (574×2 px, 150 KB)

(85999 is viewer.id)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 27 2023, 1:27 PM
Herald added a subscriber: tomek. · View Herald TranscriptApr 27 2023, 1:27 PM
atul published this revision for review.Apr 27 2023, 1:28 PM
atul edited the test plan for this revision. (Show Details)
atul updated this revision to Diff 25890.Apr 27 2023, 1:29 PM
atul edited the test plan for this revision. (Show Details)

readonly

atul edited the test plan for this revision. (Show Details)Apr 27 2023, 1:30 PM
ashoat added a comment.Apr 27 2023, 1:31 PM

Test plan before / after seems identical? Maybe I'm missing something

atul added a comment.Apr 27 2023, 1:32 PM
In D7677#227419, @ashoat wrote:

Test plan before / after seems identical? Maybe I'm missing something

Sorry, just updated screenshots

ashoat accepted this revision.Apr 27 2023, 1:33 PM

Change seems right though

This revision is now accepted and ready to land.Apr 27 2023, 1:33 PM
Harbormaster completed remote builds in B18899: Diff 25888.Apr 27 2023, 1:44 PM
Harbormaster completed remote builds in B18901: Diff 25890.
atul updated this revision to Diff 25914.Apr 28 2023, 11:10 AM

rebase and land

This revision was landed with ongoing or failed builds.Apr 28 2023, 11:11 AM
Closed by commit rCOMMa19933fc4c62: [keyserver] Fix `usersToUpdate` logic in `deleteAccount` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMa19933fc4c62: [keyserver] Fix `usersToUpdate` logic in `deleteAccount`.
Harbormaster completed remote builds in B18919: Diff 25914.Apr 28 2023, 11:27 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
deleters/
4 lines

Diff 25890

View Options

keyserver/src/deleters/account-deleters.js

Loading...