Page MenuHomePhabricator
Differential D7686

[native] Add disabled state to RegistrationButton
ClosedPublic
Actions

Authored by ashoat on Apr 29 2023, 8:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 10, 7:59 PM
Unknown Object (File)
Thu, Jan 9, 6:12 AM
Unknown Object (File)
Thu, Jan 9, 6:12 AM
Unknown Object (File)
Thu, Jan 9, 6:11 AM
Unknown Object (File)
Thu, Jan 9, 6:03 AM
Unknown Object (File)
Dec 11 2024, 3:47 AM
Unknown Object (File)
Nov 28 2024, 10:51 AM
Unknown Object (File)
Nov 25 2024, 8:57 PM
View All Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMMcb0f50d25933: [native] Add disabled state to RegistrationButton
Summary

We'll use this until somebody selects an option in the KeyserverSelection page. See designs here.

Test Plan

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/registration
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Apr 29 2023, 8:42 AM
Herald added a subscriber: tomek. · View Herald TranscriptApr 29 2023, 8:42 AM
ashoat edited the test plan for this revision. (Show Details)Apr 29 2023, 8:43 AM
ashoat added inline comments.
native/themes/colors.js
106

I discussed this with Ted and we agreed that introducing a new color here is the right approach. This corresponds to disabledButton, and is in our design system

Harbormaster completed remote builds in B18932: Diff 25931.Apr 29 2023, 9:00 AM
ashoat requested review of this revision.Apr 29 2023, 9:00 AM
ginsu accepted this revision.Apr 30 2023, 10:19 PM
This revision is now accepted and ready to land.Apr 30 2023, 10:19 PM
Closed by commit rCOMMcb0f50d25933: [native] Add disabled state to RegistrationButton (authored by ashoat). · Explain WhyMay 1 2023, 5:09 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMcb0f50d25933: [native] Add disabled state to RegistrationButton.

Revision Contents
Changeset List

PathSize
native/
account/
registration/
9 lines
33 lines
themes/
2 lines

Diff 25931

View Options

native/account/registration/keyserver-selection.react.js

Loading...
View Options

native/account/registration/registration-button.react.js

Loading...
View Options

native/themes/colors.js

Loading...