This is a naive/quick approach to hardcoding the avatar feature flag to true. Ideally we should not be using a hook anymore, but making that change would require me to go to every place this feature flag is used and update it accordingly. I personally felt that was a bit unnecessary especially after we talked today about deprecating all the avatar feature flags in the codebase sometime soon and this would take care of this using a unnecessary hook concern. (ENG-3413 considers removing and deprecating the feature flag rendering logic throughout our codebase)
Details
Details
- Reviewers
ashoat atul - Commits
- rCOMM3bb311aac241: [native] hardcode avatar feature flag to true
Avatars now always renders on native
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I don't think this is the best approach - ideally, we should change feature flags configuration by setting the flag for everyone (with appropriate code versions) to true. The benefit is that if we discover a serious issue with the feature, we could quickly disable it. After it is hardcoded, we will have to release a new version for that purpose.
My guess is that we wanted to do it quickly, and that's why we decided to do it that way, but maybe there are other reasons which I don't see at this point.
Comment Actions
Sorry, this should have been explained in the diff. The main reason we're doing it this way are the issues in ENG-3252. Many of us (myself included) are currently unable to use the avatars feature because the request consistently times out when we open the app