Page MenuHomePhabricator

[native] improve user experience for remvoing an avatar
ClosedPublic

Authored by ginsu on Apr 26 2023, 5:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 30, 2:54 PM
Unknown Object (File)
Wed, Oct 30, 2:54 PM
Unknown Object (File)
Wed, Oct 30, 2:54 PM
Unknown Object (File)
Wed, Oct 30, 2:54 PM
Unknown Object (File)
Wed, Oct 30, 2:51 PM
Unknown Object (File)
Fri, Oct 25, 7:18 AM
Unknown Object (File)
Fri, Oct 25, 7:18 AM
Unknown Object (File)
Fri, Oct 25, 7:18 AM
Subscribers

Details

Summary

This diff does two things to improve the user experince, 1. we change the copy from "Remove avatar" to "Clear avatar" and we exlcude this option too if the avatar is not set

https://linear.app/comm/issue/ENG-3804/remove-avatar-button-does-nothing-if-the-user-has-a-default-avatar

Test Plan

Please see the demo videos to see the changes I made

User avatar:

Thread avatar:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, atul.
ginsu edited the summary of this revision. (Show Details)
ginsu requested review of this revision.Apr 26 2023, 5:47 PM
This revision is now accepted and ready to land.Apr 27 2023, 10:17 AM