[native] Get rid of null check in `useUploadSelectedMedia`
ClosedPublic
Actions

Authored by atul on May 2 2023, 12:20 PM.

Details

Reviewers

ginsu
ashoat

Commits

rCOMM8f49a3be9b9c: [native] Get rid of null check in `useUploadSelectedMedia`

Summary

We moved handling of null selection "out" to the callsite. This is no longer necessary.

Test Plan

Open image gallery via EditAvatar and then dismiss it and observe that we return before reaching useUploadSelectedMedia. Also flow.

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D7700 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.May 2 2023, 12:20 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 2 2023, 12:20 PM

atul published this revision for review.May 2 2023, 12:20 PM

ginsu accepted this revision.May 2 2023, 12:23 PM

This revision is now accepted and ready to land.May 2 2023, 12:23 PM

Harbormaster completed remote builds in B18994: Diff 26014.May 2 2023, 12:41 PM

rebase and land

This revision was landed with ongoing or failed builds.May 3 2023, 6:44 AM

Closed by commit rCOMM8f49a3be9b9c: [native] Get rid of null check in `useUploadSelectedMedia` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM8f49a3be9b9c: [native] Get rid of null check in `useUploadSelectedMedia`.

Harbormaster completed remote builds in B19015: Diff 26040.May 3 2023, 7:02 AM

Revision Contents
Changeset List

Path

Size

native/

avatars/

avatar-hooks.js

8 lines

Diff 26014

View Options

native/avatars/avatar-hooks.js

[native] Get rid of null check in `useUploadSelectedMedia`ClosedPublicActions