Page MenuHomePhabricator
Differential D7724

[native] Get rid of React.cloneElement stuff in RegistrationTile
ClosedPublic
Actions

Authored by ashoat on May 4 2023, 1:13 PM.
Tags
None
Referenced Files
F3229024: D7724.id26091.diff
Tue, Nov 12, 4:19 AM
Unknown Object (File)
Mon, Nov 11, 1:27 AM
Unknown Object (File)
Mon, Nov 11, 1:27 AM
Unknown Object (File)
Mon, Nov 11, 1:27 AM
Unknown Object (File)
Mon, Nov 11, 1:26 AM
Unknown Object (File)
Tue, Nov 5, 2:11 AM
Unknown Object (File)
Thu, Oct 24, 8:35 AM
Unknown Object (File)
Thu, Oct 24, 8:35 AM
View All Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMMb1de84fd1a44: [native] Get rid of React.cloneElement stuff in RegistrationTile
Summary

At some point I wasn't just rendering header and body side-by-side. I then refactored it, but forgot to consider that pulling these apart just to put them back together later makes no sense.

Depends on D7723

Test Plan

Play around with the registrations screens, similar to the video in the preceding diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.May 4 2023, 1:13 PM
Herald added a subscriber: tomek. · View Herald TranscriptMay 4 2023, 1:13 PM
Harbormaster returned this revision to the author for changes because remote builds failed.May 4 2023, 1:14 PM
Harbormaster failed remote builds in B19057: Diff 26091!
ashoat added a comment.May 4 2023, 1:24 PM

Dang, absolutely destroyed by CI?

ashoat requested review of this revision.May 4 2023, 1:26 PM

Looks like a Buildkite issue: https://www.buildkitestatus.com/

We're getting an HTTP 28: https://phab.comm.dev/harbormaster/build/132139/

ashoat added a child revision: D7725: [native] Rename RegistrationButton state prop to variant.May 4 2023, 2:09 PM
ashoat updated this revision to Diff 26117.May 5 2023, 6:18 AM

Retrigger CI

Harbormaster completed remote builds in B19069: Diff 26117.May 5 2023, 6:36 AM
atul accepted this revision.May 8 2023, 7:27 AM
This revision is now accepted and ready to land.May 8 2023, 7:27 AM
Closed by commit rCOMMb1de84fd1a44: [native] Get rid of React.cloneElement stuff in RegistrationTile (authored by ashoat). · Explain WhyMay 8 2023, 9:36 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMb1de84fd1a44: [native] Get rid of React.cloneElement stuff in RegistrationTile.

Revision Contents
Changeset List

PathSize
native/
account/
registration/
19 lines

Diff 26117

View Options

native/account/registration/registration-tile.react.js

Loading...