Page MenuHomePhabricator
Differential D7721

[web] Introduce barebones `CommunityCreationModal`
ClosedPublic
Actions

Authored by atul on May 4 2023, 11:53 AM.
Tags
None
Referenced Files
F5124248: D7721.id26159.diff
Thu, Apr 3, 7:15 PM
Unknown Object (File)
Tue, Apr 1, 8:47 AM
Unknown Object (File)
Mar 3 2025, 1:52 AM
Unknown Object (File)
Feb 27 2025, 3:01 PM
Unknown Object (File)
Feb 27 2025, 3:01 PM
Unknown Object (File)
Feb 27 2025, 3:01 PM
Unknown Object (File)
Feb 27 2025, 3:01 PM
Unknown Object (File)
Feb 27 2025, 3:01 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM64d8883bd7ac: [web] Introduce barebones `CommunityCreationModal`
Summary

Absolute minimal CommunityCreationModal that opens when the CommunityCreationButton is clicked and is dismissed when either A. the X is clicked B. the user clicks outside of the Modal.

In subsequent diffs each part of the modal will be added piecewise.

Test Plan

Looks and behaves as expected:

8ff949.png (1×750 px, 40 KB)

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D7721 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.May 4 2023, 11:53 AM
Herald added a subscriber: tomek. · View Herald TranscriptMay 4 2023, 11:53 AM
atul edited the summary of this revision. (Show Details)May 4 2023, 11:57 AM
atul edited the test plan for this revision. (Show Details)
atul updated this revision to Diff 26088.May 4 2023, 12:02 PM

update

atul edited the test plan for this revision. (Show Details)May 4 2023, 12:02 PM
Harbormaster completed remote builds in B19053: Diff 26087.May 4 2023, 12:11 PM
Harbormaster completed remote builds in B19054: Diff 26088.May 4 2023, 12:20 PM
atul requested review of this revision.May 4 2023, 12:20 PM
ashoat accepted this revision.May 4 2023, 1:28 PM
This revision is now accepted and ready to land.May 4 2023, 1:28 PM
atul updated this revision to Diff 26159.May 8 2023, 2:35 AM

rebase before landing

Harbormaster completed remote builds in B19106: Diff 26159.May 8 2023, 2:52 AM
atul updated this revision to Diff 26162.May 8 2023, 2:58 AM

rebase

atul updated this revision to Diff 26163.May 8 2023, 3:04 AM

actually land

This revision was landed with ongoing or failed builds.May 8 2023, 3:09 AM
Closed by commit rCOMM64d8883bd7ac: [web] Introduce barebones `CommunityCreationModal` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM64d8883bd7ac: [web] Introduce barebones `CommunityCreationModal`.
Harbormaster completed remote builds in B19109: Diff 26162.May 8 2023, 3:17 AM
Harbormaster completed remote builds in B19110: Diff 26163.May 8 2023, 3:22 AM

Revision Contents
Changeset List

PathSize
web/
sidebar/
community-creation/
7 lines
24 lines
9 lines

Diff 26162

View Options

web/sidebar/community-creation/community-creation-modal.css

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Linesfunction CommunityDrawer(): React.Node {
}, []); }, []);
const communitiesComponents = drawerItemsData.map(item => ( const communitiesComponents = drawerItemsData.map(item => (
<CommunityDrawerItemCommunity <CommunityDrawerItemCommunity
itemData={item} itemData={item}
key={item.threadInfo.id} key={item.threadInfo.id}
toggleExpanded={setOpenCommunityOrClose} toggleExpanded={setOpenCommunityOrClose}
expanded={item.threadInfo.id === openCommunity} expanded={item.threadInfo.id === openCommunity}
paddingLeft={10}
/> />
)); ));
return ( return (
<ThreadListProvider> <ThreadListProvider>
<div className={css.container}>{communitiesComponents}</div> <div className={css.container}>{communitiesComponents}</div>
</ThreadListProvider> </ThreadListProvider>
); );
} }
export default CommunityDrawer; export default CommunityDrawer;
View Options

web/sidebar/community-creation/community-creation-modal.react.js

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Linesfunction CommunityDrawer(): React.Node {
}, []); }, []);
const communitiesComponents = drawerItemsData.map(item => ( const communitiesComponents = drawerItemsData.map(item => (
<CommunityDrawerItemCommunity <CommunityDrawerItemCommunity
itemData={item} itemData={item}
key={item.threadInfo.id} key={item.threadInfo.id}
toggleExpanded={setOpenCommunityOrClose} toggleExpanded={setOpenCommunityOrClose}
expanded={item.threadInfo.id === openCommunity} expanded={item.threadInfo.id === openCommunity}
paddingLeft={10}
/> />
)); ));
return ( return (
<ThreadListProvider> <ThreadListProvider>
<div className={css.container}>{communitiesComponents}</div> <div className={css.container}>{communitiesComponents}</div>
</ThreadListProvider> </ThreadListProvider>
); );
} }
export default CommunityDrawer; export default CommunityDrawer;
View Options

web/sidebar/community-picker.react.js

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Linesfunction CommunityDrawer(): React.Node {
}, []); }, []);
const communitiesComponents = drawerItemsData.map(item => ( const communitiesComponents = drawerItemsData.map(item => (
<CommunityDrawerItemCommunity <CommunityDrawerItemCommunity
itemData={item} itemData={item}
key={item.threadInfo.id} key={item.threadInfo.id}
toggleExpanded={setOpenCommunityOrClose} toggleExpanded={setOpenCommunityOrClose}
expanded={item.threadInfo.id === openCommunity} expanded={item.threadInfo.id === openCommunity}
paddingLeft={10}
/> />
)); ));
return ( return (
<ThreadListProvider> <ThreadListProvider>
<div className={css.container}>{communitiesComponents}</div> <div className={css.container}>{communitiesComponents}</div>
</ThreadListProvider> </ThreadListProvider>
); );
} }
export default CommunityDrawer; export default CommunityDrawer;