Page MenuHomePhabricator
Differential D7894

[web] Introduce `CommunityCreationKeyserverLabel`
ClosedPublic
Actions

Authored by atul on May 19 2023, 12:49 PM.
Tags
None
Referenced Files
F1705741: D7894.id26713.diff
Sun, May 5, 6:30 PM
Unknown Object (File)
Sat, May 4, 3:57 PM
Unknown Object (File)
Fri, May 3, 10:19 AM
Unknown Object (File)
Fri, May 3, 1:16 AM
Unknown Object (File)
Tue, Apr 30, 2:01 AM
Unknown Object (File)
Mon, Apr 29, 9:19 AM
Unknown Object (File)
Sun, Apr 28, 3:52 PM
Unknown Object (File)
Thu, Apr 25, 4:32 PM
View All 40 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMMebdfde6841a5: [web] Introduce `CommunityCreationKeyserverLabel`
Summary

Pulled common keyserver label out of CommunityCreationModal and CommunityCreationMembersModal.

Why not make it more general and put it in components?

It has a hardcoded keyserver name (ashoat) so I think it makes sense to keep its use as limited as possible. CommunityCreationKeyserverLabel could be the basis for a more general purpose KeyserverLabel component in the future.

Test Plan

Things continue to look as expected w/ CommunityCreationModal and CommunityCreationMembersModal.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.May 19 2023, 12:49 PM
Herald added a subscriber: tomek. · View Herald TranscriptMay 19 2023, 12:49 PM
atul published this revision for review.May 19 2023, 12:50 PM
atul edited the summary of this revision. (Show Details)
ashoat accepted this revision.May 19 2023, 12:59 PM
This revision is now accepted and ready to land.May 19 2023, 12:59 PM
atul updated this revision to Diff 26712.May 19 2023, 1:05 PM

rebase and land

This revision was landed with ongoing or failed builds.May 19 2023, 1:06 PM
Closed by commit rCOMMebdfde6841a5: [web] Introduce `CommunityCreationKeyserverLabel` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMebdfde6841a5: [web] Introduce `CommunityCreationKeyserverLabel`.
Harbormaster completed remote builds in B19532: Diff 26701.May 19 2023, 1:09 PM
Harbormaster completed remote builds in B19533: Diff 26712.May 19 2023, 1:25 PM

Revision Contents
Changeset List

Diff 26713

View Options

web/sidebar/community-creation/community-creation-keyserver-label.css

Loading...
View Options

web/sidebar/community-creation/community-creation-keyserver-label.react.js

Loading...
View Options

web/sidebar/community-creation/community-creation-members-modal.css

Loading...
View Options

web/sidebar/community-creation/community-creation-members-modal.react.js

Loading...
View Options

web/sidebar/community-creation/community-creation-modal.css

Loading...
View Options

web/sidebar/community-creation/community-creation-modal.react.js

Loading...