Paths

Table of Contentst

Differential D8007

[keyserver] Filter `MANAGE_INVITE_LINKS` permission for `native` `codeVersions` < 221
ClosedPublic
Actions

Authored by atul on May 26 2023, 1:46 PM.

Details

Reviewers

ashoat

Commits

rCOMM615e4e2804f9: [keyserver] Filter `MANAGE_INVITE_LINKS` permission for `native` `codeVersions`…

Summary

Matches what we did to filter permissions for EDIT_THREAD_AVATAR and MANAGE_PINS.

Test Plan

Close reading, can be tested by logging into client w/ codeVersion < 221 and ensuring that MANAGE_INVITE_LINKS is missing in Redux store.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.May 26 2023, 1:46 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 26 2023, 1:46 PM

atul published this revision for review.May 26 2023, 1:48 PM

ashoat accepted this revision.May 26 2023, 1:49 PM

This revision is now accepted and ready to land.May 26 2023, 1:49 PM

ashoat mentioned this in D7762: [lib] Introduce a new permission for managing invite links.May 26 2023, 1:49 PM

This revision was landed with ongoing or failed builds.May 26 2023, 1:50 PM

Closed by commit rCOMM615e4e2804f9: [keyserver] Filter `MANAGE_INVITE_LINKS` permission for `native` `codeVersions`… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM615e4e2804f9: [keyserver] Filter `MANAGE_INVITE_LINKS` permission for `native` `codeVersions`….

Harbormaster completed remote builds in B19803: Diff 27114.May 26 2023, 2:06 PM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

thread-fetchers.js

4 lines

lib/

shared/

thread-utils.js

7 lines

Diff 27114

View Options

keyserver/src/fetchers/thread-fetchers.js