Paths

Table of Contentst

Differential D8026

[web] Fix "invariant violation" for encrypted uploads
ClosedPublic
Actions

Authored by bartek on May 30 2023, 2:11 AM.

Details

Reviewers

ashoat

Commits

rCOMM11401a4d3055: [web] Fix "invariant violation" for encrypted uploads

Summary

Fixes ENG-3947. Details are in the Linear issue.

Test Plan

Sent encrypted message on web before it fully uploaded to server. Ensured there was no error in dev tools console.

Diff Detail

Repository

rCOMM Comm

Branch

barthap/invariant-violation

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.May 30 2023, 2:11 AM

Herald added subscribers: atul, tomek. · View Herald TranscriptMay 30 2023, 2:11 AM

Harbormaster completed remote builds in B19896: Diff 27255.May 30 2023, 2:29 AM

bartek requested review of this revision.May 30 2023, 2:29 AM

ashoat accepted this revision.May 30 2023, 4:37 AM

ashoat added inline comments.

web/input/input-state-container.react.js
1020	Arguably we could just use `localID` instead of `uploadAfterPreload.localID`, but it shouldn't matter

This revision is now accepted and ready to land.May 30 2023, 4:37 AM

Closed by commit rCOMM11401a4d3055: [web] Fix "invariant violation" for encrypted uploads (authored by bartek). · Explain WhyMay 30 2023, 11:36 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM11401a4d3055: [web] Fix "invariant violation" for encrypted uploads.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

message-reducer.js

13 lines

web/

input/

input-state-container.react.js

4 lines

Diff 27255

View Options

lib/reducers/message-reducer.js