Page MenuHomePhabricator
Differential D8129

[native] Introduce `addSelectedUsersToCommunity` to `CommunityCreationMembers`
ClosedPublic
Actions

Authored by atul on Jun 6 2023, 11:01 AM.
Tags
None
Referenced Files
F3399222: D8129.id27500.diff
Mon, Dec 2, 2:30 AM
F3399092: D8129.id27564.diff
Mon, Dec 2, 1:44 AM
F3399040: D8129.id27563.diff
Mon, Dec 2, 1:33 AM
F3398711: D8129.diff
Mon, Dec 2, 12:11 AM
Unknown Object (File)
Mon, Nov 18, 10:54 AM
Unknown Object (File)
Oct 28 2024, 1:04 PM
Unknown Object (File)
Oct 26 2024, 11:11 PM
Unknown Object (File)
Sep 29 2024, 6:13 AM
View All 76 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM7ca83617d0e2: [native] Introduce `addSelectedUsersToCommunity` to `CommunityCreationMembers`
Summary

Introduce addSelectedUsersToCommunity which adds selected users to the newly created community when the user hits "Done." In next diff we will navigate to the newly created community after successful creation.

Depends on D8122

Test Plan

Check community and ensure that users were added as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 6 2023, 11:01 AM
Herald added a subscriber: tomek. · View Herald TranscriptJun 6 2023, 11:01 AM
Harbormaster completed remote builds in B20069: Diff 27500.Jun 6 2023, 11:19 AM
atul requested review of this revision.Jun 6 2023, 11:19 AM
atul added a child revision: D8130: [native] Navigate to newly created community after successful creation.Jun 6 2023, 11:26 AM
ashoat accepted this revision.Jun 7 2023, 12:35 PM
ashoat added inline comments.
native/community-creation/community-creation-members.react.js
114–126

Nit: I personally would find this more readable without the ternary

This revision is now accepted and ready to land.Jun 7 2023, 12:35 PM
atul added inline comments.Jun 7 2023, 12:48 PM
native/community-creation/community-creation-members.react.js
114–126

Good point, this probably falls under "no ternaries in JSX," will update

atul updated this revision to Diff 27563.Jun 8 2023, 10:28 AM

address feedback

This revision was landed with ongoing or failed builds.Jun 8 2023, 10:40 AM
Closed by commit rCOMM7ca83617d0e2: [native] Introduce `addSelectedUsersToCommunity` to `CommunityCreationMembers` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM7ca83617d0e2: [native] Introduce `addSelectedUsersToCommunity` to `CommunityCreationMembers`.
Harbormaster completed remote builds in B20119: Diff 27563.Jun 8 2023, 10:45 AM

Revision Contents
Changeset List

PathSize
native/
community-creation/
76 lines

Diff 27500

View Options

native/community-creation/community-creation-members.react.js

Loading...