[keyserver] Don't specify name for new PRIVATE threads
ClosedPublic
Actions

Authored by ashoat on Apr 15 2023, 11:25 AM.

Details

Reviewers

tomek
atul

Commits

rCOMM4edbbc2d2871: [keyserver] Don't specify name for new PRIVATE threads
rCOMM1a0a8d941d78: [keyserver] Don't specify name for new PRIVATE threads

Summary

Now that we display PRIVATE threads without names with the ENS-resolved username of the member, we can skip specifying the name of the thread.

Depends on D7453

Test Plan

In combination with the preceding diff, I tested this by deleting and recreating my ashoat.eth account in my local web environment, and confirming that my new PRIVATE thread was displayed with the name "ashoat.eth"

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 15 2023, 11:25 AM

ashoat added a child revision: D7455: [keyserver] Migration to reset all PRIVATE thread names.Apr 15 2023, 11:42 AM

Harbormaster completed remote builds in B18384: Diff 25189.Apr 15 2023, 11:43 AM

ashoat requested review of this revision.Apr 15 2023, 11:43 AM

tomek accepted this revision.Apr 17 2023, 4:44 AM

This revision is now accepted and ready to land.Apr 17 2023, 4:44 AM

Closed by commit rCOMM1a0a8d941d78: [keyserver] Don't specify name for new PRIVATE threads (authored by ashoat). · Explain WhyApr 17 2023, 4:41 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM1a0a8d941d78: [keyserver] Don't specify name for new PRIVATE threads.

ashoat reopened this revision.Apr 17 2023, 4:43 PM

This revision is now accepted and ready to land.Apr 17 2023, 4:43 PM

ashoat added a reverting change: rCOMMd9b54c68548b: Revert "[keyserver] Don't specify name for new PRIVATE threads".Apr 17 2023, 4:43 PM

In retrospect I should hold off on landing this until D7453 is shipped to clients first. It only affects user registration and we can assume they will be using newer client versions, but we should still wait until it actually ships before landing this, in order to avoid blocking keyserver deploy

Closed by commit rCOMM4edbbc2d2871: [keyserver] Don't specify name for new PRIVATE threads (authored by ashoat). · Explain WhyJun 12 2023, 8:05 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM4edbbc2d2871: [keyserver] Don't specify name for new PRIVATE threads.