Page MenuHomePhabricator
Differential D7453

[lib] Introduce new ifJustViewer field in ThreadEntity for PRIVATE threads
ClosedPublic
Actions

Authored by ashoat on Apr 15 2023, 11:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 10:34 PM
Unknown Object (File)
Mon, Dec 9, 10:34 PM
Unknown Object (File)
Sun, Dec 8, 6:36 PM
Unknown Object (File)
Thu, Dec 5, 2:28 AM
Unknown Object (File)
Thu, Dec 5, 2:28 AM
Unknown Object (File)
Nov 15 2024, 2:06 AM
Unknown Object (File)
Nov 14 2024, 11:02 PM
Unknown Object (File)
Nov 14 2024, 10:34 PM
View All Files
Subscribers
None

Details

Reviewers
tomek
atul
Commits
rCOMMa5ce04f66d57: [lib] Introduce new ifJustViewer field in ThreadEntity for PRIVATE threads
Summary

We currently name new ENS users' PRIVATE threads after their wallet address. In order to instead display their ENS name, we want to make the EntityText framework support some way to render an unnamed PRIVATE thread's name as just their username.

Currently we display such threads as "just you". In this diff, we introduce a new ifJustViewer field to make it possible to show "ashoat.eth" instead.

Test Plan

In combination with the following diff, I tested this by deleting and recreating my ashoat.eth account in my local web environment, and confirming that my new PRIVATE thread was displayed with the name "ashoat.eth"

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 15 2023, 11:24 AM
ashoat added a child revision: D7454: [keyserver] Don't specify name for new PRIVATE threads.
ashoat edited the test plan for this revision. (Show Details)Apr 15 2023, 11:25 AM
ashoat mentioned this in D7455: [keyserver] Migration to reset all PRIVATE thread names.Apr 15 2023, 11:42 AM
Harbormaster completed remote builds in B18383: Diff 25188.Apr 15 2023, 11:42 AM
ashoat requested review of this revision.Apr 15 2023, 11:42 AM
tomek accepted this revision.Apr 17 2023, 4:36 AM
tomek added inline comments.
lib/shared/thread-utils.js
873–876 ↗(On Diff #25188)

We can probably avoid this logic by implementing thread type specs - just like for message types. Then we would have a method that has one implementation for PRIVATE and one for other types. Obviously, this refactoring would be a lot more complicated than this, but we can consider it in the future.

lib/utils/entity-text.js
248–249 ↗(On Diff #25188)

It isn't intuitive to ignore viewer when viewer username mode is selected.

This revision is now accepted and ready to land.Apr 17 2023, 4:36 AM
ashoat added inline comments.Apr 17 2023, 5:01 AM
lib/shared/thread-utils.js
873–876 ↗(On Diff #25188)

Agree that we should do this

lib/utils/entity-text.js
248–249 ↗(On Diff #25188)

I'll add a comment

ashoat updated this revision to Diff 25238.Apr 17 2023, 4:40 PM

Add code comment

This revision was landed with ongoing or failed builds.Apr 17 2023, 4:41 PM
Closed by commit rCOMMa5ce04f66d57: [lib] Introduce new ifJustViewer field in ThreadEntity for PRIVATE threads (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMa5ce04f66d57: [lib] Introduce new ifJustViewer field in ThreadEntity for PRIVATE threads.
ashoat mentioned this in D7454: [keyserver] Don't specify name for new PRIVATE threads.Apr 17 2023, 4:44 PM
Harbormaster completed remote builds in B18425: Diff 25238.Apr 17 2023, 4:57 PM
ashoat mentioned this in rCOMM5231a4122892: [keyserver] Migration to reset all PRIVATE thread names.Jun 12 2023, 8:05 AM

Revision Contents
Changeset List

PathSize
lib/
shared/
4 lines
utils/
23 lines

Diff 25239

View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/utils/entity-text.js

Loading...