HomePhabricator
Diffusion Comm 9ddc64a1c283

[native] Left-align pending thread header titles

Tags
None
Referenced Files
F490839: 2023-04-17 14.48.15.mp4
Apr 17 2023, 12:41 PM
File Not Attached
F490838: 2023-04-17 14.47.35.mp4
Apr 17 2023, 12:41 PM
File Not Attached
Subscribers

Description

[native] Left-align pending thread header titles

Summary:
We currently center-align a MessageListHeaderTitle if it is searchEmpty ("New Message" with no users selected), or if it is a pending thread (see definition of areSettingsEnabled).

Center-aligned the header title for pending threads is inconsistent with behavior for normal threads. Discussed this with Ted and @ginsu and we decided it would be more consistent to always left-align, except in the "New Message" case.

Some previous context in D7134. Linear task: ENG-3693

Test Plan:

beforeafter

Reviewers: ginsu, atul

Reviewed By: ginsu

Subscribers: tomek, ginsu

Differential Revision: https://phab.comm.dev/D7474

Details

Provenance
ashoatAuthored on Apr 17 2023, 11:50 AM
Reviewer
ginsu
Differential Revision
D7474: [native] Left-align pending thread header titles
Parents
rCOMMfebd68fc0df8: [lib] introduce getEthAddressForUserInfo helper function
Branches
Unknown
Tags
Unknown