Paths

Table of Contentst

Differential D7474

[native] Left-align pending thread header titles
ClosedPublic
Actions

Authored by ashoat on Apr 17 2023, 11:52 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 28, 1:35 AM

	Unknown Object (File)
	Sun, Apr 28, 1:35 AM

	Unknown Object (File)
	Sun, Apr 28, 1:33 AM

	Unknown Object (File)
	Sun, Apr 28, 1:11 AM

	Unknown Object (File)
	Mar 28 2024, 8:33 AM

	Unknown Object (File)
	Mar 28 2024, 8:33 AM

	Unknown Object (File)
	Mar 28 2024, 8:32 AM

	Unknown Object (File)
	Mar 28 2024, 8:30 AM

View All 59 Files

Subscribers

Details

Reviewers

ginsu
atul

Commits

rCOMM9ddc64a1c283: [native] Left-align pending thread header titles

Summary

We currently center-align a MessageListHeaderTitle if it is searchEmpty ("New Message" with no users selected), or if it is a pending thread (see definition of areSettingsEnabled).

Center-aligned the header title for pending threads is inconsistent with behavior for normal threads. Discussed this with Ted and @ginsu and we decided it would be more consistent to always left-align, except in the "New Message" case.

Some previous context in D7134. Linear task: ENG-3693

Test Plan

before	after

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 17 2023, 11:52 AM

Herald added a subscriber: tomek. · View Herald TranscriptApr 17 2023, 11:52 AM

ashoat edited the summary of this revision. (Show Details)Apr 17 2023, 11:54 AM

ashoat edited the test plan for this revision. (Show Details)

ashoat added inline comments.

native/chat/chat.react.js
48 ↗	(On Diff #25230)	Unrelated cleanup. I asked @ginsu to look for other instances of this

Harbormaster completed remote builds in B18419: Diff 25230.Apr 17 2023, 12:10 PM

ashoat requested review of this revision.Apr 17 2023, 12:10 PM

ginsu accepted this revision.Apr 17 2023, 12:30 PM

ginsu added inline comments.

native/chat/chat.react.js
48 ↗	(On Diff #25230)	Thanks for catching this, just double checked for other TODO related avatar comments I left and this is the only one

This revision is now accepted and ready to land.Apr 17 2023, 12:30 PM

Closed by commit rCOMM9ddc64a1c283: [native] Left-align pending thread header titles (authored by ashoat). · Explain WhyApr 17 2023, 12:41 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM9ddc64a1c283: [native] Left-align pending thread header titles.

Revision Contents
Changeset List

Path

Size

native/

chat/

4 lines

Diff 25232

native/chat/chat.react.js

Loading...