Page MenuHomePhabricator
Differential D7474

[native] Left-align pending thread header titles
ClosedPublic
Actions

Authored by ashoat on Apr 17 2023, 11:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 5:21 AM
Unknown Object (File)
Mon, Nov 18, 11:58 PM
Unknown Object (File)
Wed, Nov 6, 3:29 AM
Unknown Object (File)
Tue, Nov 5, 4:30 AM
Unknown Object (File)
Tue, Nov 5, 4:30 AM
Unknown Object (File)
Tue, Nov 5, 4:30 AM
Unknown Object (File)
Thu, Oct 31, 5:45 PM
Unknown Object (File)
Thu, Oct 31, 5:45 PM
View All Files
Subscribers
ginsu
tomek

Details

Reviewers
ginsu
atul
Commits
rCOMM9ddc64a1c283: [native] Left-align pending thread header titles
Summary

We currently center-align a MessageListHeaderTitle if it is searchEmpty ("New Message" with no users selected), or if it is a pending thread (see definition of areSettingsEnabled).

Center-aligned the header title for pending threads is inconsistent with behavior for normal threads. Discussed this with Ted and @ginsu and we decided it would be more consistent to always left-align, except in the "New Message" case.

Some previous context in D7134. Linear task: ENG-3693

Test Plan
beforeafter

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 17 2023, 11:52 AM
Herald added a subscriber: tomek. · View Herald TranscriptApr 17 2023, 11:52 AM
ashoat edited the summary of this revision. (Show Details)Apr 17 2023, 11:54 AM
ashoat edited the test plan for this revision. (Show Details)
ashoat added inline comments.
native/chat/chat.react.js
48 ↗(On Diff #25230)

Unrelated cleanup. I asked @ginsu to look for other instances of this

Harbormaster completed remote builds in B18419: Diff 25230.Apr 17 2023, 12:10 PM
ashoat requested review of this revision.Apr 17 2023, 12:10 PM
ginsu accepted this revision.Apr 17 2023, 12:30 PM
ginsu added inline comments.
native/chat/chat.react.js
48 ↗(On Diff #25230)

Thanks for catching this, just double checked for other TODO related avatar comments I left and this is the only one

This revision is now accepted and ready to land.Apr 17 2023, 12:30 PM
Closed by commit rCOMM9ddc64a1c283: [native] Left-align pending thread header titles (authored by ashoat). · Explain WhyApr 17 2023, 12:41 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM9ddc64a1c283: [native] Left-align pending thread header titles.

Revision Contents
Changeset List

PathSize
native/
chat/
4 lines

Diff 25232

View Options

native/chat/chat.react.js

Loading...