[electron-update-server] Ignore older releases
ClosedPublic
Actions

Authored by michal on Jun 14 2023, 6:59 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMMb4bdb4f1131f: [electron-update-server] Ignore older releases

Summary

Fix for https://linear.app/comm/issue/ENG-4073
hazel (the update server for electron) has these issues:

it depends on the ordering of releases returned by GitHub API, which isn't guaranteed
it only checks if the new version from GitHub is different than the currently cached version

This diffs adds sorting of the results from github and checks if the new release is (semver) greater than the currently cached.

Test Plan

Check with a test repo:

add a new release, check if it's cached
add a new release that has a lower semver, check that it's skipped

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Jun 14 2023, 6:59 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJun 14 2023, 6:59 AM

Retrigger ci

Harbormaster completed remote builds in B20254: Diff 27754.Jun 14 2023, 9:46 AM

michal requested review of this revision.Jun 14 2023, 9:46 AM

kamil requested changes to this revision.Jun 15 2023, 3:11 AM

kamil added inline comments.

patches/hazel-server+5.1.1.patch
17–27 ↗	(On Diff #27754)	can be simplified
31–35 ↗	(On Diff #27754)	Correct me if I am wrong but looks like we can modify this condition here and avoid sorting, since at the end we care only about the latest version

This revision now requires changes to proceed.Jun 15 2023, 3:11 AM

Moved all conditions (version has to be newer, release has to have assets) to the find condition instead of skipping them after one release is chosen. This way we don't ignore the rest of release from github api

Harbormaster completed remote builds in B20285: Diff 27806.Jun 15 2023, 8:31 AM

kamil accepted this revision.Jun 16 2023, 2:38 AM

This revision is now accepted and ready to land.Jun 16 2023, 2:38 AM

Closed by commit rCOMMb4bdb4f1131f: [electron-update-server] Ignore older releases (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyJun 19 2023, 1:32 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMb4bdb4f1131f: [electron-update-server] Ignore older releases.

michal mentioned this in D8305: [electron-update-server] Introduce new version.Jun 23 2023, 2:44 AM

Michal Gniadek <michal.gniadek@swmansion.com> mentioned this in rCOMMab08c20a59d7: [electron-update-server] Introduce new version.Jun 29 2023, 10:37 AM