Paths

Table of Contentst

[web][lib][landing] Prevent crash when missing WalletConnect key
ClosedPublic
Actions

Authored by ashoat on Jun 27 2023, 9:24 PM.

Tags

None

Referenced Files

	F3354280: D8349.id28202.diff
	Sat, Nov 23, 12:42 PM

	F3354225: D8349.id28238.diff
	Sat, Nov 23, 12:26 PM

	F3352781: D8349.id.diff
	Sat, Nov 23, 7:08 AM

	Unknown Object (File)
	Tue, Nov 19, 12:43 AM

	Unknown Object (File)
	Thu, Nov 7, 6:33 AM

	Unknown Object (File)
	Mon, Oct 28, 12:00 PM

	Unknown Object (File)
	Oct 2 2024, 8:01 AM

	Unknown Object (File)
	Oct 2 2024, 8:01 AM

View All 92 Files

Subscribers

tomek

Details

Reviewers

kamil
atul

Commits

rCOMM71601d39d173: [web][lib][landing] Prevent crash when missing WalletConnect key

Summary

See ENG-4175 for context.

Test Plan

I moved my keyserver/secrets/walletconnect.json file to another path. Without this diff the web app was crashing, but after this diff it was able to load successfully.

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/walletconnect

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jun 27 2023, 9:24 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 27 2023, 9:24 PM

Harbormaster completed remote builds in B20567: Diff 28202.Jun 27 2023, 9:42 PM

ashoat requested review of this revision.Jun 27 2023, 9:42 PM

I checked and it resolved the issue for me

This revision is now accepted and ready to land.Jun 28 2023, 1:49 AM

Closed by commit rCOMM71601d39d173: [web][lib][landing] Prevent crash when missing WalletConnect key (authored by ashoat). · Explain WhyJun 28 2023, 3:57 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM71601d39d173: [web][lib][landing] Prevent crash when missing WalletConnect key.

Revision Contents
Changeset List

Path

Size

landing/

siwe.react.js

23 lines

lib/

utils/

wagmi-utils.js

23 lines

Diff 28202

View Options

landing/siwe.react.js