Paths

Table of Contentst

[web/native] Small changes to the change roles stack
ClosedPublic
Actions

Authored by rohan on Jun 29 2023, 9:12 AM.

Details

Reviewers

atul
ashoat

Commits

rCOMM591346204cc7: [web/native] Small changes to the change roles stack

Summary

There were three suggestions left across the change-roles stack, and they were all small enough that I thought it made sense to just cover it all in one diff. The three changes are:

Use shorthand for createChangeThreadMemberRolesPromise

Remove a <>...</> that doesn't do anything

Move the activity indicator styles down to unboundStyles

Test Plan

Confirmed that everything still works as expected

Diff Detail

Repository

rCOMM Comm

Branch

change_roles-quickfix

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Jun 29 2023, 9:12 AM

Herald added a subscriber: tomek. · View Herald TranscriptJun 29 2023, 9:12 AM

Harbormaster completed remote builds in B20620: Diff 28270.Jun 29 2023, 9:30 AM

rohan requested review of this revision.Jun 29 2023, 9:30 AM

ashoat accepted this revision.Jun 30 2023, 1:09 AM

This revision is now accepted and ready to land.Jun 30 2023, 1:09 AM

Closed by commit rCOMM591346204cc7: [web/native] Small changes to the change roles stack (authored by rohan). · Explain WhyJun 30 2023, 7:42 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM591346204cc7: [web/native] Small changes to the change roles stack.

Revision Contents
Changeset List

Path

Size

native/

roles/

change-roles-screen.react.js

11 lines

web/

modals/

threads/

members/

change-member-role-modal.react.js

25 lines

Diff 28270

View Options

native/roles/change-roles-screen.react.js