Paths

Table of Contentst

Differential D8386

[lib] Enable new id schema
ClosedPublic
Actions

Authored by michal on Jun 30 2023, 3:25 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 12:05 AM

	Unknown Object (File)
	Fri, Dec 20, 12:01 AM

	Unknown Object (File)
	Thu, Dec 19, 11:33 PM

	Unknown Object (File)
	Thu, Dec 19, 11:23 PM

	Unknown Object (File)
	Thu, Dec 19, 11:04 PM

	Unknown Object (File)
	Thu, Dec 19, 10:55 PM

	Unknown Object (File)
	Thu, Dec 19, 10:46 PM

	Unknown Object (File)
	Thu, Dec 19, 10:43 PM

Subscribers

Details

Reviewers

kamil
tomek

Commits

rCOMMc383d785b898: [lib] Enable new id schema
rCOMM98ea2834e2b6: [lib] Enable new id schema

Summary

Bump state versions, and replace FUTURE_CODE_VERSION. Also remove the flag blocking the conversions, because after migrations had run, the code on the clients should run unconditionally, and the keyserver changes are version gated anyway, so this flag is not needed.

Depends on D8383, D8385

Test Plan

N/A

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Jun 30 2023, 3:25 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJun 30 2023, 3:25 AM

Harbormaster completed remote builds in B20636: Diff 28288.Jun 30 2023, 3:42 AM

michal requested review of this revision.Jun 30 2023, 3:42 AM

kamil mentioned this in D8383: [web] Migrate to new id schema.Jul 3 2023, 4:26 AM

Moved all state version bumps, and FUTURE_CODE_VERSION replacements here, so nothing will break if we land only part of this stack.

Update summary

Harbormaster completed remote builds in B20712: Diff 28381.Jul 4 2023, 6:16 AM

Harbormaster completed remote builds in B20713: Diff 28382.Jul 4 2023, 6:20 AM

kamil accepted this revision.Jul 4 2023, 8:13 AM

This revision is now accepted and ready to land.Jul 4 2023, 8:13 AM

michal added a parent revision: D8460: [clients] Handle notifs with old id schema.Jul 10 2023, 1:19 AM

Rebase

Harbormaster completed remote builds in B20843: Diff 28548.Jul 10 2023, 6:41 AM

Use hasMinCodeVersion from the previous diff. Don't split NEXT_CODE_VERSION per platform as it's not needed anymore.

michal added a parent revision: D8466: [lib] Add hasMinStateVersion.Jul 10 2023, 10:26 AM

Harbormaster completed remote builds in B20850: Diff 28558.Jul 10 2023, 10:43 AM

Replaced types with any as discussed in D8355

Harbormaster completed remote builds in B20901: Diff 28624.Jul 12 2023, 6:12 AM

Closed by commit rCOMM98ea2834e2b6: [lib] Enable new id schema (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyJul 13 2023, 2:18 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM98ea2834e2b6: [lib] Enable new id schema.

Michal Gniadek <michal.gniadek@swmansion.com> added a reverting change: rCOMM71d98690eae0: Revert "[lib] Enable new id schema".Jul 13 2023, 7:04 AM

michal reopened this revision.Jul 18 2023, 6:40 AM

This revision is now accepted and ready to land.Jul 18 2023, 6:40 AM

Also remove convertToNewIDSchema from genesis.js

Harbormaster completed remote builds in B20988: Diff 28773.Jul 18 2023, 6:59 AM

Closed by commit rCOMMc383d785b898: [lib] Enable new id schema (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyJul 18 2023, 8:49 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMc383d785b898: [lib] Enable new id schema.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

utils/

validation-utils.js

21 lines

lib/

_generated/

migration-utils.js

32 lines

selectors/

socket-selectors.js

45 lines

utils/

validation-utils.js

2 lines

native/

redux/

2 lines

web/

redux/

2 lines

Diff 28663

keyserver/src/utils/validation-utils.js

Loading...

lib/_generated/migration-utils.js

Loading...

lib/selectors/socket-selectors.js

Loading...

lib/utils/validation-utils.js

Loading...

native/redux/persist.js

Loading...

web/redux/persist.js

Loading...