Page MenuHomePhabricator

[keyserver] rename napi add_reserved_usernames function
ClosedPublic

Authored by varun on Jul 18 2023, 12:38 PM.
Tags
None
Referenced Files
F3369522: D8533.id28799.diff
Mon, Nov 25, 10:47 PM
F3368676: D8533.diff
Mon, Nov 25, 8:38 PM
Unknown Object (File)
Mon, Nov 11, 3:09 AM
Unknown Object (File)
Sat, Nov 9, 6:59 AM
Unknown Object (File)
Oct 11 2024, 1:12 PM
Unknown Object (File)
Oct 11 2024, 1:12 PM
Unknown Object (File)
Oct 11 2024, 1:11 PM
Unknown Object (File)
Oct 11 2024, 1:09 PM
Subscribers

Details

Summary

accidentally renamed addReservedUsername -> addReservedUsernames in JS without making the corresponding change to the rust function name.

i think i missed this when i split out D8300 into multiple diffs. should've tested more thoroughly after splitting and rebasing

Test Plan

Registered a new user and saw the new username (albert) in my reserved usernames DDB table

Also deleted albert's account and saw that the username was removed from the table

2023-07-18T19:29:13.715822Z INFO identity::database: Batch write item to reserved usernames table succeeded
2023-07-18T19:30:51.876524Z INFO identity::database: Username albert has been deleted from reserved usernames table

Diff Detail

Repository
rCOMM Comm
Branch
typo (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage