[native] Retry feature flags call
ClosedPublic
Actions

Authored by tomek on Jul 31 2023, 7:26 AM.

Details

Reviewers

kamil
bartek

Commits

rCOMMc700760617fd: [native] Retry feature flags call

Summary

Retry feature flags call. If number of tries is exceeded, rethrow an error.

Depends on D8652

Test Plan

Add console logs and simulate failed requests - the requests should be retried up to numberOfTries times with delays.

Diff Detail

Repository

rCOMM Comm

Branch

feature-flags-timeout

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Jul 31 2023, 7:26 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 31 2023, 7:26 AM

Harbormaster completed remote builds in B21373: Diff 29277.Jul 31 2023, 9:11 AM

tomek requested review of this revision.Jul 31 2023, 9:11 AM

bartek added inline comments.Jul 31 2023, 9:33 AM

native/components/feature-flags-provider.react.js
111 ↗	(On Diff #29277)	You can skip last sleep because there will be no more retries from then, it only delays the rethrow

Avoid sleep before throwing

native/components/feature-flags-provider.react.js
111 ↗	(On Diff #29277)	Yeah, you're obviously right

Harbormaster completed remote builds in B21449: Diff 29419.Aug 1 2023, 4:17 AM

bartek accepted this revision.Aug 1 2023, 6:47 AM

This revision is now accepted and ready to land.Aug 1 2023, 6:47 AM

Closed by commit rCOMMc700760617fd: [native] Retry feature flags call (authored by tomek). · Explain WhyAug 1 2023, 8:36 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMc700760617fd: [native] Retry feature flags call.

Revision Contents
Changeset List

Path

Size

native/

components/

feature-flags-provider.react.js

30 lines

Diff 29419

View Options

native/components/feature-flags-provider.react.js

[native] Retry feature flags callClosedPublicActions