[web] Call `baseSetUserAvatar` from `onImageSelected`
ClosedPublic
Actions

Authored by atul on Aug 4 2023, 1:22 AM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMMcf12040be85f: [web] Call `baseSetUserAvatar` from `onImageSelected`

Summary

Once image is successfully uploaded, we make call to baseSetUserAvatar from EditUserAvatarContext.

As of this diff, users can set emoji, image, ENS avatars (and remove them). What's missing is ImageAvatarSelectionModal to handle cropping + some error handling. Those will be handled after the thread avatar work.

Depends on D8725

Test Plan

Works as expected:

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Aug 4 2023, 1:22 AM

Herald added a subscriber: tomek. · View Herald TranscriptAug 4 2023, 1:22 AM

atul edited the test plan for this revision. (Show Details)Aug 4 2023, 1:22 AM

Harbormaster completed remote builds in B21525: Diff 29530.Aug 4 2023, 1:40 AM

atul requested review of this revision.Aug 4 2023, 1:40 AM

ashoat accepted this revision.Aug 4 2023, 6:43 AM

This revision is now accepted and ready to land.Aug 4 2023, 6:43 AM

Closed by commit rCOMMcf12040be85f: [web] Call `baseSetUserAvatar` from `onImageSelected` (authored by atul). · Explain WhyAug 4 2023, 2:41 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMcf12040be85f: [web] Call `baseSetUserAvatar` from `onImageSelected`.

Revision Contents
Changeset List

Path

Size

web/

avatars/

edit-user-avatar-menu.react.js

7 lines

Diff 29530

View Options

web/avatars/edit-user-avatar-menu.react.js

[web] Call `baseSetUserAvatar` from `onImageSelected`ClosedPublicActions