Paths

Table of Contentst

[lib] Rename `setThreadAvatar` to `baseSetThreadAvatar` in `EditThreadAvatarProvider`
ClosedPublic
Actions

Authored by atul on Aug 8 2023, 9:01 AM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMMaae18d4b8285: [lib] Rename `setThreadAvatar` to `baseSetThreadAvatar` in…

Summary

Thread avatar equivalent of D8344

We want devs to use the platform-specific setThreadAvatar wrappers rather than interfacing w/ setThreadAvatar from provider directly... so renaming to make that more clear.

Depends on D8758

Test Plan

flow/eslint/searched codebase for "setThreadAvatar."

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Aug 8 2023, 9:01 AM

Herald added a subscriber: tomek. · View Herald TranscriptAug 8 2023, 9:01 AM

atul published this revision for review.Aug 8 2023, 9:04 AM

Harbormaster completed remote builds in B21587: Diff 29614.Aug 8 2023, 9:19 AM

ashoat accepted this revision.Aug 8 2023, 2:13 PM

This revision is now accepted and ready to land.Aug 8 2023, 2:13 PM

rebase and land

Harbormaster completed remote builds in B21669: Diff 29783.Aug 9 2023, 6:20 AM

This revision was landed with ongoing or failed builds.Aug 9 2023, 6:23 AM

Closed by commit rCOMMaae18d4b8285: [lib] Rename `setThreadAvatar` to `baseSetThreadAvatar` in…. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMaae18d4b8285: [lib] Rename `setThreadAvatar` to `baseSetThreadAvatar` in….

Harbormaster completed remote builds in B21670: Diff 29784.Aug 9 2023, 6:37 AM

Revision Contents
Changeset List

Path

Size

lib/

components/

base-edit-thread-avatar-provider.react.js

10 lines

native/

avatars/

avatar-hooks.js

6 lines

Diff 29614

View Options

lib/components/base-edit-thread-avatar-provider.react.js