Page MenuHomePhabricator
Differential D8822

[landing] decrease spacing between paragraphs in landing page info blocks
ClosedPublic
Actions

Authored by ginsu on Aug 15 2023, 12:43 PM.
Tags
None
Referenced Files
F2256307: D8822.id29926.diff
Fri, Jul 12, 10:40 PM
Unknown Object (File)
Thu, Jul 11, 5:47 AM
Unknown Object (File)
Thu, Jul 11, 2:59 AM
Unknown Object (File)
Thu, Jul 11, 2:19 AM
Unknown Object (File)
Sat, Jul 6, 6:19 PM
Unknown Object (File)
Sat, Jul 6, 4:27 PM
Unknown Object (File)
Sat, Jun 15, 11:26 AM
Unknown Object (File)
Jun 10 2024, 7:24 PM
View All 31 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMM14ce9b0351a2: [landing] decrease spacing between paragraphs in landing page info blocks
Summary

@ashoat brought this up IRL, this diff addresses decreasing the spacing between paragraphs from 40px => 24px.

Test Plan

Please see screenshots below

Before:

Screenshot 2023-08-15 at 3.40.22 PM.png (2×3 px, 865 KB)

Screenshot 2023-08-15 at 3.40.24 PM.png (2×3 px, 820 KB)

After:

Screenshot 2023-08-15 at 3.40.02 PM.png (2×3 px, 830 KB)

Screenshot 2023-08-15 at 3.40.04 PM.png (2×3 px, 870 KB)

Diff Detail

Repository
rCOMM Comm
Branch
final-landing-page-touchups
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Aug 15 2023, 12:43 PM
Herald added a subscriber: tomek. · View Herald TranscriptAug 15 2023, 12:43 PM
Harbormaster completed remote builds in B21772: Diff 29925.Aug 15 2023, 1:02 PM
ginsu requested review of this revision.Aug 15 2023, 1:02 PM
ginsu updated this revision to Diff 29926.Aug 15 2023, 1:04 PM

quick fix

ginsu edited the summary of this revision. (Show Details)Aug 15 2023, 1:06 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, atul.
ginsu attached a referenced file: F690401: Screenshot 2023-08-15 at 3.40.04 PM.png. (Show Details)
ginsu attached a referenced file: F690400: Screenshot 2023-08-15 at 3.40.02 PM.png. (Show Details)
ginsu attached a referenced file: F690398: Screenshot 2023-08-15 at 3.40.24 PM.png. (Show Details)
ginsu attached a referenced file: F690399: Screenshot 2023-08-15 at 3.40.22 PM.png. (Show Details)
ginsu added inline comments.
landing/info-block.css
23 ↗(On Diff #29926)

We add 16px here since we removed 16px from the paragraph class below

ginsu added inline comments.Aug 15 2023, 1:15 PM
landing/landing.css
44 ↗(On Diff #29926)

Switched from margin to padding here since this was causing margin collapse

ashoat accepted this revision.Aug 15 2023, 1:21 PM
This revision is now accepted and ready to land.Aug 15 2023, 1:21 PM
Harbormaster completed remote builds in B21773: Diff 29926.Aug 15 2023, 1:24 PM
Closed by commit rCOMM14ce9b0351a2: [landing] decrease spacing between paragraphs in landing page info blocks (authored by ginsu). · Explain WhyAug 15 2023, 1:29 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM14ce9b0351a2: [landing] decrease spacing between paragraphs in landing page info blocks.

Revision Contents
Changeset List

PathSize
landing/
1 line
2 lines

Diff 29925

View Options

landing/info-block.css

Loading...
View Options

landing/landing.css

Loading...