[keyserver] Test impact of improving encoding on Ashoat's ThreadStore
ClosedPublic
Actions

Authored by ashoat on Sep 29 2023, 1:28 PM.

Details

Reviewers

atul
tomek

Commits

rCOMM744748a96b9a: [keyserver] Test impact of improving encoding on Ashoat's ThreadStore

Summary

This diff stack introduces a script that tests various different approaches to reducing the size of the ThreadStore. We may or may not land it... the goal is just to get some numbers.

Depends on D9336

Test Plan

Run the script:

after improving encoding, Ashoat's ThreadStore is 11123335 bytes large

Corresponds to 10.61 MiB, which is a reduction of 84.63%.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Sep 29 2023, 1:28 PM

ashoat added a child revision: D9338: [keyserver] Test impact of introduction of isAdminRole on Ashoat's ThreadStore.Sep 29 2023, 1:30 PM

Harbormaster completed remote builds in B22931: Diff 31570.Sep 29 2023, 1:49 PM

ashoat requested review of this revision.Sep 29 2023, 1:49 PM

atul accepted this revision.Sep 29 2023, 7:34 PM

This revision is now accepted and ready to land.Sep 29 2023, 7:34 PM

Closed by commit rCOMM744748a96b9a: [keyserver] Test impact of improving encoding on Ashoat's ThreadStore (authored by ashoat). · Explain WhySep 30 2023, 5:27 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM744748a96b9a: [keyserver] Test impact of improving encoding on Ashoat's ThreadStore.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

scripts/

test-threadstore-reductions.js

138 lines

Diff 31570

View Options

keyserver/src/scripts/test-threadstore-reductions.js

// @flow		// @flow

import invariant from 'invariant';		import invariant from 'invariant';
import _debounce from 'lodash/debounce.js';		import _debounce from 'lodash/debounce.js';
import * as React from 'react';		import * as React from 'react';

import { useModalContext } from 'lib/components/modal-provider.react.js';		import { useModalContext } from 'lib/components/modal-provider.react.js';
		import SWMansionIcon from 'lib/components/SWMansionIcon.react.js';
import type { ChatMessageInfoItem } from 'lib/selectors/chat-selectors.js';		import type { ChatMessageInfoItem } from 'lib/selectors/chat-selectors.js';
		import { useCanEditMessage } from 'lib/shared/edit-messages-utils.js';
import { createMessageReply } from 'lib/shared/message-utils.js';		import { createMessageReply } from 'lib/shared/message-utils.js';
import { useCanCreateReactionFromMessage } from 'lib/shared/reaction-utils.js';		import { useCanCreateReactionFromMessage } from 'lib/shared/reaction-utils.js';
import {		import {
threadHasPermission,		threadHasPermission,
useSidebarExistsOrCanBeCreated,		useSidebarExistsOrCanBeCreated,
} from 'lib/shared/thread-utils.js';		} from 'lib/shared/thread-utils.js';
import { messageTypes } from 'lib/types/message-types-enum.js';		import { messageTypes } from 'lib/types/message-types-enum.js';
import { isComposableMessageType } from 'lib/types/message-types.js';		import { isComposableMessageType } from 'lib/types/message-types.js';
▲ Show 20 Lines • Show All 202 Lines • ▼ Show 20 Lines	return React.useMemo(() => {
return {		return {
actionButtonContent: buttonContent,		actionButtonContent: buttonContent,
onClick: onClickTogglePin,		onClick: onClickTogglePin,
label: isPinned ? 'Unpin' : 'Pin',		label: isPinned ? 'Unpin' : 'Pin',
};		};
}, [canTogglePin, inputState, isPinned, pushModal, item, threadInfo]);		}, [canTogglePin, inputState, isPinned, pushModal, item, threadInfo]);
}		}

		function useMessageEditAction(
		item: ChatMessageInfoItem,
		threadInfo: ThreadInfo,
		): ?MessageTooltipAction {
		const { messageInfo } = item;

		const canEditMessage = useCanEditMessage(threadInfo, messageInfo);

		return React.useMemo(() => {
		if (!canEditMessage) {
		return null;
		}
		const buttonContent = (
		<SWMansionIcon icon="edit-1" size={18} disableFill={false} />
		);
		const onClickEdit = () => {
		// TODO: Enter edit mode
		};
		return {
		actionButtonContent: buttonContent,
		onClick: onClickEdit,
		label: 'Edit',
		};
		}, [canEditMessage]);
		}

function useMessageTooltipActions(		function useMessageTooltipActions(
item: ChatMessageInfoItem,		item: ChatMessageInfoItem,
threadInfo: ThreadInfo,		threadInfo: ThreadInfo,
): $ReadOnlyArray<MessageTooltipAction> {		): $ReadOnlyArray<MessageTooltipAction> {
const sidebarAction = useMessageTooltipSidebarAction(item, threadInfo);		const sidebarAction = useMessageTooltipSidebarAction(item, threadInfo);
const replyAction = useMessageTooltipReplyAction(item, threadInfo);		const replyAction = useMessageTooltipReplyAction(item, threadInfo);
const copyAction = useMessageCopyAction(item);		const copyAction = useMessageCopyAction(item);
const reactAction = useMessageReactAction(item, threadInfo);		const reactAction = useMessageReactAction(item, threadInfo);
const togglePinAction = useMessageTogglePinAction(item, threadInfo);		const togglePinAction = useMessageTogglePinAction(item, threadInfo);
		const editAction = useMessageEditAction(item, threadInfo);
return React.useMemo(		return React.useMemo(
() =>		() =>
[		[
replyAction,		replyAction,
sidebarAction,		sidebarAction,
copyAction,		copyAction,
reactAction,		reactAction,
togglePinAction,		togglePinAction,
		editAction,
].filter(Boolean),		].filter(Boolean),
[replyAction, sidebarAction, copyAction, reactAction, togglePinAction],		[
		replyAction,
		sidebarAction,
		copyAction,
		reactAction,
		togglePinAction,
		editAction,
		],
);		);
}		}

type UseMessageTooltipArgs = {		type UseMessageTooltipArgs = {
+availablePositions: $ReadOnlyArray<TooltipPosition>,		+availablePositions: $ReadOnlyArray<TooltipPosition>,
+item: ChatMessageInfoItem,		+item: ChatMessageInfoItem,
+threadInfo: ThreadInfo,		+threadInfo: ThreadInfo,
};		};
▲ Show 20 Lines • Show All 187 Lines • Show Last 20 Lines

[keyserver] Test impact of improving encoding on Ashoat's ThreadStoreClosedPublicActions