Minor improvments to NSE code
ClosedPublic
Actions

Authored by marcin on Oct 6 2023, 9:31 AM.

Tags

None

Referenced Files

	F3373458: D9400.id31748.diff
	Tue, Nov 26, 9:48 AM

	F3371503: D9400.id32214.diff
	Tue, Nov 26, 4:49 AM

	F3370337: D9400.diff
	Tue, Nov 26, 2:08 AM

	Unknown Object (File)
	Fri, Nov 22, 6:23 PM

	Unknown Object (File)
	Sun, Oct 27, 11:19 PM

	Unknown Object (File)
	Oct 17 2024, 7:25 PM

	Unknown Object (File)
	Oct 17 2024, 7:24 PM

	Unknown Object (File)
	Oct 17 2024, 7:24 PM

View All 74 Files

Subscribers

will

Details

Reviewers

tomek
ashoat

Commits

rCOMM6835d8e3a1e6: Minor improvments to NSE code

Summary

This differential addresses two issues that Ashoat discovered in my past diffs. The first one: https://phab.comm.dev/D7814, the second one:
https://phab.comm.dev/D8795.

Test Plan

Build iOS app and ensure encrypted notifications are working as previously.

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-4886

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Oct 6 2023, 9:31 AM

Herald added a subscriber: will. · View Herald TranscriptOct 6 2023, 9:31 AM

Harbormaster completed remote builds in B23058: Diff 31748.Oct 6 2023, 9:50 AM

marcin requested review of this revision.Oct 6 2023, 9:50 AM

ashoat accepted this revision.Oct 9 2023, 1:45 PM

This revision is now accepted and ready to land.Oct 9 2023, 1:45 PM

Rebase before landing

Harbormaster completed remote builds in B23370: Diff 32214.Oct 19 2023, 8:49 AM

Closed by commit rCOMM6835d8e3a1e6: Minor improvments to NSE code (authored by marcin). · Explain WhyOct 19 2023, 8:54 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM6835d8e3a1e6: Minor improvments to NSE code.

Revision Contents
Changeset List

Path

Size

native/

ios/

NotificationService/

NotificationService.mm

4 lines

Diff 31748

View Options

native/ios/NotificationService/NotificationService.mm

Minor improvments to NSE codeClosedPublicActions