Minor improvments to NSE code
ClosedPublic
Actions

Authored by marcin on Oct 6 2023, 9:31 AM.

Details

Reviewers

tomek
ashoat

Commits

rCOMM6835d8e3a1e6: Minor improvments to NSE code

Summary

This differential addresses two issues that Ashoat discovered in my past diffs. The first one: https://phab.comm.dev/D7814, the second one:
https://phab.comm.dev/D8795.

Test Plan

Build iOS app and ensure encrypted notifications are working as previously.

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-4886

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Oct 6 2023, 9:31 AM

Herald added a subscriber: will. · View Herald TranscriptOct 6 2023, 9:31 AM

Harbormaster completed remote builds in B23058: Diff 31748.Oct 6 2023, 9:50 AM

marcin requested review of this revision.Oct 6 2023, 9:50 AM

ashoat accepted this revision.Oct 9 2023, 1:45 PM

This revision is now accepted and ready to land.Oct 9 2023, 1:45 PM

Rebase before landing

Harbormaster completed remote builds in B23370: Diff 32214.Oct 19 2023, 8:49 AM

Closed by commit rCOMM6835d8e3a1e6: Minor improvments to NSE code (authored by marcin). · Explain WhyOct 19 2023, 8:54 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM6835d8e3a1e6: Minor improvments to NSE code.

Revision Contents
Changeset List

Path

Size

native/

ios/

NotificationService/

NotificationService.mm

4 lines

Diff 31748

View Options

native/ios/NotificationService/NotificationService.mm

Show First 20 Lines • Show All 64 Lines • ▼ Show 20 Lines	const tPlatform: TEnums = t.enums.of([
'windows',		'windows',
'macos',		'macos',
]);		]);
const tDeviceType: TEnums = t.enums.of(['ios', 'android']);		const tDeviceType: TEnums = t.enums.of(['ios', 'android']);
const tPlatformDetails: TInterface<PlatformDetails> = tShape({		const tPlatformDetails: TInterface<PlatformDetails> = tShape({
platform: tPlatform,		platform: tPlatform,
codeVersion: t.maybe(t.Number),		codeVersion: t.maybe(t.Number),
stateVersion: t.maybe(t.Number),		stateVersion: t.maybe(t.Number),
		majorDesktopVersion: t.maybe(t.Number),
});		});
const tPassword: TRefinement<string> = t.refinement(		const tPassword: TRefinement<string> = t.refinement(
t.String,		t.String,
(password: string) => !!password,		(password: string) => !!password,
);		);
const tCookie: TRegex = tRegex(/^(user\|anonymous)=[0-9]+:[0-9a-f]+$/);		const tCookie: TRegex = tRegex(/^(user\|anonymous)=[0-9]+:[0-9a-f]+$/);
const tEmail: TRegex = tRegex(validEmailRegex);		const tEmail: TRegex = tRegex(validEmailRegex);
const tOldValidUsername: TRegex = tRegex(oldValidUsernameRegex);		const tOldValidUsername: TRegex = tRegex(oldValidUsernameRegex);
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines

Minor improvments to NSE codeClosedPublicActions