Implemented Display and TryFrom impls to generated DeviceType object in grpc_clients/identity/src/device.rs.
Being able to marshal the protobuf into a "more realized" object will likely be useful in the future for both devices and services.
Details
Details
- Reviewers
varun - Commits
- rCOMMe78de5e00497: Implement Display and TryFrom traits for DeviceType
Write unit tests located in grpc_clients/identity/src/device.rs for both Display and TryFrom.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
can you elaborate a little on your test plan?
| shared/grpc_clients/src/error.rs | ||
|---|---|---|
| 6–15 ↗ | (On Diff #31729) | thanks for filling in the placeholder. can you please do something similar for the other variants? |
| shared/grpc_clients/src/identity/device.rs | ||
| 1–4 ↗ | (On Diff #31729) | nit: can we use crate:: instead of super::? i prefer crate:: because if we reorganize files later it's one less thing to think about and then group the imports like this:
this is just a best practice thing |