Minor improvments to NSE code
ClosedPublic
Actions

Authored by marcin on Oct 6 2023, 9:31 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Oct 27, 11:19 PM

	Unknown Object (File)
	Thu, Oct 17, 7:25 PM

	Unknown Object (File)
	Thu, Oct 17, 7:24 PM

	Unknown Object (File)
	Thu, Oct 17, 7:24 PM

	Unknown Object (File)
	Thu, Oct 17, 7:13 PM

	Unknown Object (File)
	Sep 29 2024, 2:43 AM

	Unknown Object (File)
	Sep 6 2024, 4:17 PM

	Unknown Object (File)
	Sep 6 2024, 4:17 PM

View All 70 Files

Subscribers

will

Details

Reviewers

tomek
ashoat

Commits

rCOMM6835d8e3a1e6: Minor improvments to NSE code

Summary

This differential addresses two issues that Ashoat discovered in my past diffs. The first one: https://phab.comm.dev/D7814, the second one:
https://phab.comm.dev/D8795.

Test Plan

Build iOS app and ensure encrypted notifications are working as previously.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Oct 6 2023, 9:31 AM

Herald added a subscriber: will. · View Herald TranscriptOct 6 2023, 9:31 AM

Harbormaster completed remote builds in B23058: Diff 31748.Oct 6 2023, 9:50 AM

marcin requested review of this revision.Oct 6 2023, 9:50 AM

ashoat accepted this revision.Oct 9 2023, 1:45 PM

This revision is now accepted and ready to land.Oct 9 2023, 1:45 PM

Rebase before landing

Harbormaster completed remote builds in B23370: Diff 32214.Oct 19 2023, 8:49 AM

Closed by commit rCOMM6835d8e3a1e6: Minor improvments to NSE code (authored by marcin). · Explain WhyOct 19 2023, 8:54 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM6835d8e3a1e6: Minor improvments to NSE code.

Revision Contents
Changeset List

Path

Size

native/

ios/

NotificationService/

NotificationService.mm

4 lines

Diff 32216

View Options

native/ios/NotificationService/NotificationService.mm

Minor improvments to NSE codeClosedPublicActions