[native] fix iOS build on x86_64
ClosedPublic
Actions

Authored by varun on Nov 14 2023, 1:47 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMMa46af06af356: [native] fix iOS build on x86_64

Summary

In the Library Search Paths section of our Xcode project, we list:

"$(SRCROOT)/../native_rust_library/target/aarch64-apple-ios/release",
"$(SRCROOT)/../native_rust_library/target/x86_64-apple-ios/release",

When we build for Any iOS Device (arm64), Xcode locates the arm64 static library in the first search path. Then, when we build for Simulator (x86_64), Xcode again locates the arm64 static library in the first search path, and we get an error.

If we haven't previously built for Any iOS Device (arm64), when we build for Simulator (x86_64), Xcode doesn't find anything in the first search path, locates the x86_64 static library in the second search path, and builds successfully.

The solution is to set the search paths conditionally.

Test Plan

built the app for any iOS device, then for simulator, then did an archive build (release). All succeeded. Tried them in various orders just to be sure.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Nov 14 2023, 1:47 PM

Herald added a subscriber: tomek. · View Herald TranscriptNov 14 2023, 1:47 PM

varun added inline comments.Nov 14 2023, 1:48 PM

native/ios/Comm.xcodeproj/project.pbxproj
1252 ↗	(On Diff #33224)	We have to include `"$(inherited)",` so that the above paths are also searched

Harbormaster completed remote builds in B24122: Diff 33224.Nov 14 2023, 2:07 PM

varun requested review of this revision.Nov 14 2023, 2:07 PM

ashoat accepted this revision.Nov 14 2023, 3:44 PM

ashoat added a reviewer: atul.

ashoat added inline comments.

native/ios/Comm.xcodeproj/project.pbxproj
1255–1258 ↗	(On Diff #33224)	This line seems to lock us into running Rosetta in the Simulator... is there any other discriminant you can use other than `sdk=`, eg. `arch=` or something? If not can you add a comment to ENG-3613 so we remember we'll need to address this later?